Merge lp:~openerp-dev/openobject-addons/7.0-opw-607044-rgo into lp:openobject-addons/7.0

[Ravi Gohil (OpenERP)]

Steps to reproduce the issue:
1. Create a db and load the "French(BE)" lang for the admin user
2. Open the product "[CARD] Carte graphique" in form view
3. duplicate the product "Carte graphique"

Issue1: you will have "Graphics Card (copie)" as the name for duplicated product instead of "Carte graphique (copie)"

4. change the name of the duplicated product in step "3" to eg. "Graphics Card2" and save
5. duplicate the product created in step "4"

Issue2: the new suggested name for product created in step "5" will be the same like on the first duplicate("Graphics Card (copie)") instead of "Graphics Card2 (copie)"

This is because the wrong values are set for product_template's name field in the ir.translation table when duplicating the product.

I have fixed this issue by managing this case for product object by overriding the copy_translations(...), kindly review the fix and share your views on it.

Thanks.

[Martin Trigaux (OpenERP) (mat-openerp)]

Hello,

The expected behaviour is the following

If my user is in english when duplicating
[en] Graphic Card -> Graphic Card (copy)
[fr] Carte Graphique -> Carte Graphique
We keep the same translation in french as we want to avoid people with lots of translation to manually reenter the translation

If my user is in french when duplicating
[fr] Carte Graphique -> Carte Graphique (copie)
[en] Graphic Card -> Graphic Card

There was indeed an issue in case of product which had a different behaviour. It is now fixed in 7.0 at revision 10041.
I reject this one them.

Unmerged revisions

10035. By Ravi Gohil (OpenERP) on 2014-05-06

[FIX] product: Duplicating product in other than en_US lang sets wrong translation for product template name, courtesy: Jay Vora (Serpent Consulting Services), referenced lp bug# 734191. (Maintenance Case: 607044)

=== modified file 'product/product.py'
--- product/product.py	2014-04-25 12:55:07 +0000
+++ product/product.py	2014-05-06 10:15:13 +0000
@@ -721,6 +721,22 @@
 
         return res
 
+    def copy_translations(self, cr, uid, old_id, new_id, context=None):
+        if context is None:
+            context = {}
+        super(product_product, self).copy_translations(cr, uid, old_id, new_id, context=context)
+        trans_obj = self.pool.get('ir.translation')
+        template_id = self.browse(cr, uid, new_id, context=context).product_tmpl_id.id
+        trans_ids = trans_obj.search(cr, uid, [('res_id','=',template_id), ('name','=','product.template,name')])
+        trans_records = trans_obj.read(cr, uid, trans_ids, ['src','value','lang'])
+        for trans_rec in trans_records:
+            context['lang'] = trans_rec['lang']
+            trans_rec['src'] += ' (copy)'
+            trans_rec['value'] += _(' (copy)')
+            tr_id = trans_rec['id']
+            del trans_rec['id']
+            trans_obj.write(cr, uid, [tr_id], trans_rec)
+
     def copy(self, cr, uid, id, default=None, context=None):
         if context is None:
             context={}
@@ -734,7 +750,7 @@
         context_wo_lang.pop('lang', None)
         product = self.read(cr, uid, id, ['name'], context=context_wo_lang)
         default = default.copy()
-        default.update(name=_("%s (copy)") % (product['name']))
+        default.update(name=("%s (copy)") % (product['name']))
 
         if context.get('variant',False):
             fields = ['product_tmpl_id', 'active', 'variants', 'default_code',
@@ -749,7 +765,7 @@
             return self.create(cr, uid, data)
         else:
             return super(product_product, self).copy(cr, uid, id, default=default,
-                    context=context)
+                    context=context_wo_lang)
 
     def search(self, cr, uid, args, offset=0, limit=None, order=None, context=None, count=False):
         if context is None: