Merge lp:~openerp-dev/openobject-addons/7.0-opw-606399-ado into lp:openobject-addons/7.0

Proposed by Amit Dodiya (OpenERP)
Status: Rejected
Rejected by: Martin Trigaux (OpenERP)
Proposed branch: lp:~openerp-dev/openobject-addons/7.0-opw-606399-ado
Merge into: lp:openobject-addons/7.0
Diff against target: 21 lines (+2/-2)
1 file modified
hr_payroll_account/hr_payroll_account.py (+2/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/7.0-opw-606399-ado
Reviewer Review Type Date Requested Status
Naresh(OpenERP) Pending
Review via email: mp+215799@code.launchpad.net

Description of the change

Hello,

FIX]hr_payroll_account: set partner_id in all journal entries created from payslip

Issue:
partner_id is not added in all journal items created from hr payslip, partner_id is only added on receivable/payable account entries.

For reproduce the issue refer the bug: https://bugs.launchpad.net/openobject-addons/+bug/1304507

Regards,
Amit Dodiya

To post a comment you must log in.
Revision history for this message
Martin Trigaux (OpenERP) (mat-openerp) wrote :

As discussed on the bug report, this is the expected behaviour. Rejecting this one then.

Unmerged revisions

9981. By Amit Dodiya (OpenERP)

[FIX]hr_payroll_account: set partner_id in all journal entries created from payslip

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hr_payroll_account/hr_payroll_account.py'
2--- hr_payroll_account/hr_payroll_account.py 2014-03-04 11:31:17 +0000
3+++ hr_payroll_account/hr_payroll_account.py 2014-04-15 04:44:33 +0000
4@@ -159,7 +159,7 @@
5 adjust_credit = (0, 0, {
6 'name': _('Adjustment Entry'),
7 'date': timenow,
8- 'partner_id': False,
9+ 'partner_id': partner_id,
10 'account_id': acc_id,
11 'journal_id': slip.journal_id.id,
12 'period_id': period_id,
13@@ -175,7 +175,7 @@
14 adjust_debit = (0, 0, {
15 'name': _('Adjustment Entry'),
16 'date': timenow,
17- 'partner_id': False,
18+ 'partner_id': partner_id,
19 'account_id': acc_id,
20 'journal_id': slip.journal_id.id,
21 'period_id': period_id,