Merge lp:~openerp-dev/openobject-addons/7.0-opw-605218-ado into lp:openobject-addons/7.0

[Amit Dodiya (OpenERP)]

Hello,

[FIX] project: users are able to create tasks on closed project and also able to see the closed project on dropdown list(of project) on task form

1st Issue - User is able to search the closed project on many2one dropdown on task form:
Steps:
1). Create a new project(for e.g: test), cancel it
2). Now create a task from task menu and type test on many2one field of project
You will find the closed project on list

2nd Issue - User is able to create task from closed project by opening tasks menu from Tasks button on project form:
Steps:
1). Create a new project(for e.g: test), cancel it
2). Now you have tasks button on project, click on it and try to create task
You will see the task is created from that closed project

Regards,
Amit Dodiya

[Denis Ledoux (OpenERP) (dle-openerp)]

While it seems indeed right to not attach tasks to closed projects, you should not prevent totally user to do so.

In a general matter, we have to keep OpenERP as generic as possible, and this is possible that some users want to be able to attach tasks to closed projects.

Nevertheless, you can help them to avoid doing this mistake by adding a domain on the project field on the tasks view. One line patch.

review: Disapprove

[Amit Dodiya (OpenERP) (ado-openerp)]

Hello Denis,

I have improved the code as per the suggestion.

Regards,
Amit

review: Needs Resubmitting

=== modified file 'project/project.py'
--- project/project.py	2014-02-06 17:27:02 +0000
+++ project/project.py	2014-03-21 06:10:55 +0000
@@ -575,6 +575,15 @@
             model_ids = self.pool.get('ir.model').search(cr, uid, [('model', '=', vals.get('alias_model', 'project.task'))])
             vals.update(alias_model_id=model_ids[0])
         return super(project, self).write(cr, uid, ids, vals, context=context)
+    
+    def name_search(self, cr, uid, name, args=None, operator='ilike', context=None, limit=100):
+        if not args:
+            args = []
+        if context is None:
+            context = {}
+        ids = self.search(cr, uid, [('state', '!=', 'close'), ('name', operator, name)] + args, limit=limit, context=context)
+        return self.name_get(cr, uid, ids, context or {})
+
 
 class task(base_stage, osv.osv):
     _name = "project.task"
@@ -1125,6 +1134,10 @@
     def create(self, cr, uid, vals, context=None):
         if context is None:
             context = {}
+        if vals.get('project_id'):
+            project_record = self.pool.get('project.project').browse(cr, uid, vals.get('project_id'), context=context)
+            if project_record.state == 'close':
+                raise osv.except_osv(_('Warning !'), _('You can not create tasks on closed project.'))
         if vals.get('project_id') and not context.get('default_project_id'):
             context['default_project_id'] = vals.get('project_id')