Merge lp:~openerp-dev/openobject-addons/7.0-opw-598208-ado into lp:openobject-addons/7.0

[Amit Dodiya (OpenERP)]

Hello,

[FIX]: Fixes issues related to warning while running pylint script for undefined variables on some files

Run this command "pylint -E filename.py" on terminal for below files and you will find warnings related to undefined variables.
account/report/account_print_overdue.py
account/wizard/account_financial_report.py
account_followup/report/account_followup_print.py
base_report_designer/plugin/openerp_report_designer/bin/script/lib/tools.py
document_ftp/ftpserver/authorizer.py
document_webdav/test_davclient.py
mrp_repair/wizard/make_invoice.py
report_webkit/webkit_report.py

Regards,
Amit

Unmerged revisions

9526. By Amit Dodiya (OpenERP) on 2013-10-17

[FIX]: Fixes issues related warning while running pylint scrip for undefined variables

=== modified file 'account/report/account_print_overdue.py'
--- account/report/account_print_overdue.py	2012-12-06 14:56:32 +0000
+++ account/report/account_print_overdue.py	2013-10-18 05:49:39 +0000
@@ -42,7 +42,7 @@
         addresses = res_partner.address_get(self.cr, self.uid, [partner.id], ['invoice'])
         adr_id = addresses and addresses['invoice'] or False
         if adr_id:
-            adr=res_partner_address.read(self.cr, self.uid, [adr_id])[0]
+            adr=res_partner.read(self.cr, self.uid, [adr_id])[0]
             return adr['phone']
         else:
             return partner.phone or False

=== modified file 'account/wizard/account_financial_report.py'
--- account/wizard/account_financial_report.py	2013-09-03 09:27:32 +0000
+++ account/wizard/account_financial_report.py	2013-10-18 05:49:39 +0000
@@ -20,6 +20,7 @@
 ##############################################################################
 
 from openerp.osv import fields, osv
+from openerp.tools.translate import _
 
 class accounting_report(osv.osv_memory):
     _name = "accounting.report"

=== modified file 'account_followup/report/account_followup_print.py'
--- account_followup/report/account_followup_print.py	2013-01-03 09:48:18 +0000
+++ account_followup/report/account_followup_print.py	2013-10-18 05:49:39 +0000
@@ -24,6 +24,8 @@
 
 from openerp import pooler
 from openerp.report import report_sxw
+from openerp.osv import osv
+from openerp.tools.translate import _
 
 class report_rappel(report_sxw.rml_parse):
     _name = "account_followup.report.rappel"

=== modified file 'base_report_designer/plugin/openerp_report_designer/bin/script/lib/tools.py'
--- base_report_designer/plugin/openerp_report_designer/bin/script/lib/tools.py	2013-03-04 17:31:32 +0000
+++ base_report_designer/plugin/openerp_report_designer/bin/script/lib/tools.py	2013-10-18 05:49:39 +0000
@@ -20,6 +20,7 @@
 #
 ##############################################################################
 import urllib
+import os
 
 def get_absolute_file_path(url):
     url_unquoted = urllib.unquote(url)

=== modified file 'document_ftp/ftpserver/authorizer.py'
--- document_ftp/ftpserver/authorizer.py	2011-01-14 00:11:01 +0000
+++ document_ftp/ftpserver/authorizer.py	2013-10-18 05:49:39 +0000
@@ -1,4 +1,6 @@
 # -*- encoding: utf-8 -*-
+from openerp import pooler
+from openerp.service import security
 
 class authorizer:
     read_perms = "elr"

=== modified file 'document_webdav/test_davclient.py'
--- document_webdav/test_davclient.py	2013-05-14 14:28:37 +0000
+++ document_webdav/test_davclient.py	2013-10-18 05:49:39 +0000
@@ -55,7 +55,7 @@
     def __init__(self, use_datetime=0):
         self._use_datetime = use_datetime
         self._http = {}
-        log.debug("Using persistent transport")
+        _logger.debug("Using persistent transport")
 
     def make_connection(self, host):
         # create a HTTP connection object from a host descriptor
@@ -252,7 +252,7 @@
                     (atype,realm) = resp.msg.getheader('www-authenticate').split(' ',1)
                     data1 = resp.read()
                     if data1:
-                        log.warning("Why have data on a 401 auth. message?")
+                        _logger.warning("Why have data on a 401 auth. message?")
                     if realm.startswith('realm="') and realm.endswith('"'):
                         realm = realm[7:-1]
                     _logger.debug("Resp: %r %r", resp.version,resp.isclosed(), resp.will_close)
@@ -401,7 +401,7 @@
         try:
                 r1 = conn.getresponse()
         except httplib.BadStatusLine, bsl:
-                log.warning("Bad status line: %s", bsl.line)
+                _logger.warning("Bad status line: %s", bsl.line)
                 raise Exception('Bad status line.')
         if r1.status == 401: # and r1.headers:
                 if 'www-authenticate' in r1.msg:

=== modified file 'mrp_repair/wizard/make_invoice.py'
--- mrp_repair/wizard/make_invoice.py	2012-12-17 14:43:06 +0000
+++ mrp_repair/wizard/make_invoice.py	2013-10-18 05:49:39 +0000
@@ -57,7 +57,7 @@
         form_res = mod_obj.get_object_reference(cr, uid, 'account', 'invoice_form')
         form_id = form_res and form_res[1] or False
         tree_res = mod_obj.get_object_reference(cr, uid, 'account', 'invoice_tree')
-        tree_id = tree_res and tree_res[1] or Fals
+        tree_id = tree_res and tree_res[1] or False
 
         return {
             'domain': [('id','in', newinv.values())],

=== modified file 'report_webkit/webkit_report.py'
--- report_webkit/webkit_report.py	2013-06-11 14:10:16 +0000
+++ report_webkit/webkit_report.py	2013-10-18 05:49:39 +0000
@@ -46,6 +46,7 @@
 from openerp import pooler
 from report_helper import WebKitHelper
 from openerp.report.report_sxw import *
+from openerp.report.report_sxw import report_sxw
 from openerp import addons
 from openerp import tools
 from openerp.tools.translate import _