Merge lp:~openerp-dev/openobject-addons/7.0-opw-596231-rgo into lp:openobject-addons/7.0

[Ravi Gohil (OpenERP)]

Steps to reproduce:
1) Create a record for lead, select a customer(onchange partner will set it's related fields),
2) Remove the value for that customer and save it,
3) Launch the "Convert to Opportunity" wizard and choose any option other than 'Link to an existing customer' and create opportunity.

Result Expected:
If "Create a new customer" was selected, it should create a new customer and link it to the opportunity and if "Do not link to a customer" was selected, it should have created the opportunity with no customer selected.

Current Result:
Once the system suggested any existing partner to link with, it does not serve the expected result for options "Create a new customer" and "Do not link to a customer" and always link the suggested partner to that opportunity.

Issue is caused as once the system suggested partner was set in the wizard and when the other options selected it simply just hid the partner field and never cleared it's value which then going to be passed to _create_partner(...) and result into this bug.

I have fixed it by clearing the partner by mean of an onchange on the action field.

Kindly review the fix.

Thanks.

[Naresh(OpenERP) (nch-openerp)]

LGTM

review: Approve

=== modified file 'crm/wizard/crm_lead_to_opportunity.py'
--- crm/wizard/crm_lead_to_opportunity.py	2013-06-07 11:38:29 +0000
+++ crm/wizard/crm_lead_to_opportunity.py	2013-08-13 07:16:36 +0000
@@ -37,6 +37,9 @@
         'opportunity_ids': fields.many2many('crm.lead', string='Opportunities'),
     }
 
+    def onchange_action(self, cr, uid, ids, action, context=None):
+        return {'value': {'partner_id': False if action != 'exist' else self._find_matching_partner(cr, uid, context=context)}}
+
     def default_get(self, cr, uid, fields, context=None):
         """
         Default get for name, opportunity_ids.

=== modified file 'crm/wizard/crm_lead_to_opportunity_view.xml'
--- crm/wizard/crm_lead_to_opportunity_view.xml	2013-02-08 10:47:13 +0000
+++ crm/wizard/crm_lead_to_opportunity_view.xml	2013-08-13 07:16:36 +0000
@@ -27,7 +27,7 @@
                         </field>
                     </group>
                     <group name="action" attrs="{'invisible': [('name', '!=', 'convert')]}">
-                        <field name="action" class="oe_inline"/>
+                        <field name="action" on_change="onchange_action(action, context)" class="oe_inline"/>
                         <field name="partner_id"
                             attrs="{'required': [('action', '=', 'exist')], 'invisible':[('action','!=','exist')]}"
                             class="oe_inline"/>