Merge lp:~openerp-dev/openobject-addons/7.0-opw-596206-fka into lp:openobject-addons/7.0

[Foram Katharotiya (OpenERP)]

Hello,

I have fixed the bug of expense when we create account.move.line to account.move from expense. It's give traceback of ref field.

Thanks,
FKA

[Olivier Dony (Odoo) (odo-openerp)]

Your patch is wrong because you're taking the characters *after* 64 instead of *before*!! Please review and test the actual effect of your code before submitting it.

In any case, it seems clear to me that the right fix is to correct fields.function to properly apply the size limit that was set on it when the type is "char". In this case `ref` is a fields.related which is also a fields.function that is stored, so this is the source of the bug. It will also avoid hardcoding a limit in the code while the one of the model should be used.

Martin Trigaux is preparing a branch to fix this.

Thanks!

review: Disapprove

Unmerged revisions

9347. By Foram Katharotiya (OpenERP) on 2013-08-05

[IMP] trimmed ref field in expense.py

=== modified file 'hr_expense/hr_expense.py'
--- hr_expense/hr_expense.py	2013-05-22 17:49:45 +0000
+++ hr_expense/hr_expense.py	2013-08-06 04:54:30 +0000
@@ -258,7 +258,7 @@
                     'date_maturity': exp.date_confirm, 
                     'amount_currency': diff_currency_p and total_currency or False, 
                     'currency_id': diff_currency_p and exp.currency_id.id or False, 
-                    'ref': exp.name
+                    'ref': exp.name[64:]
                     })
 
             #convert eml into an osv-valid format