Merge lp:~openerp-dev/openobject-addons/7.0-opw-595596-han into lp:openobject-addons/7.0

Proposed by Hardik Ansodariya (OpenERP)
Status: Approved
Approved by: Naresh(OpenERP)
Approved revision: 9329
Proposed branch: lp:~openerp-dev/openobject-addons/7.0-opw-595596-han
Merge into: lp:openobject-addons/7.0
Diff against target: 21 lines (+3/-1)
1 file modified
stock/product_view.xml (+3/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/7.0-opw-595596-han
Reviewer Review Type Date Requested Status
Juan Rial (OpenERP) (community) Disapprove
Naresh(OpenERP) (community) Approve
Review via email: mp+178515@code.launchpad.net

Description of the change

Hello,

Relocated the active field into Inventory/ Status from Procurement/ Delay in product form.

With reference of maintenance case: 595596.

Thanks

To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) :
review: Approve
Revision history for this message
Juan Rial (OpenERP) (jri-openerp) wrote :

Rejected: The 7.0 branch is stable, so only bugfixes go in. Please resubmit against trunk.

Note: I don't disagree with the contents of the patch, only with the target branch. The patch itself looks sensible.

Thanks.

review: Disapprove

Unmerged revisions

9329. By Hardik Ansodariya (OpenERP)

[IMP] product: changed the position of active field from Procurement/Delay to Inventory/status Tab(Maintenace case: 595596)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'stock/product_view.xml'
2--- stock/product_view.xml 2012-11-29 22:26:45 +0000
3+++ stock/product_view.xml 2013-08-05 08:53:31 +0000
4@@ -74,7 +74,6 @@
5 <div attrs="{'invisible':[('type','=','service')]}">
6 <field name="produce_delay" class="oe_inline"/> days
7 </div>
8- <field name="active"/>
9 </group>
10 </group>
11 <xpath expr="//group[@string='Sale Conditions']" position="inside">
12@@ -83,6 +82,9 @@
13 <field name="sale_delay" class="oe_inline"/> days
14 </div>
15 </xpath>
16+ <group name="status" position="inside" version="7.0">
17+ <field name="active"/>
18+ </group>
19 <group name="status" position="before" version="7.0">
20 <group string="Stock and Expected Variations" attrs="{'invisible': [('type', '=', 'service')]}" groups="base.group_user">
21 <label for="qty_available"/>