Merge lp:~openerp-dev/openobject-addons/7.0-opw-595464-fka into lp:openobject-addons/7.0

[Foram Katharotiya (OpenERP)]

Hello,

I have fixed following issue.

Steps to reproduce :
1. Go-to Portal -> Billing -> Invoices
2. Create an invoice and save it, It will give traceback : TypeError: unhashable type: 'list'

Thanks,
FKA

[Rifakat Husen (OpenERP) (rha-openerp)]

Hi Foram,

This problem is already been fixed with 7.0, could you please check with updated source code?
Also this fix is wrong, your fix forbids showing customer refund invoices for portal users where it should
show both customer invoices and refund.

Here is the correct revision,
http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/9227

Thanks,
Rifakat

review: Disapprove

[Rifakat Husen (OpenERP) (rha-openerp)]

Foram,

There is no way a portal user can create an invoice so the use case if actually wrong. Hence we don't need this fix.
However, I checked that the refund journal is not getting displayed from portal invoice menu.

Could you please fix that?

Thanks a lot for your work,
Rifakat

review: Needs Fixing

Unmerged revisions

9305. By Foram Katharotiya (OpenERP) on 2013-07-22

[IMP] remove TypeError: unhashable type: 'list'

=== modified file 'portal_sale/portal_sale_view.xml'
--- portal_sale/portal_sale_view.xml	2013-03-25 14:50:36 +0000
+++ portal_sale/portal_sale_view.xml	2013-07-25 04:52:32 +0000
@@ -64,7 +64,7 @@
             <field name="res_model">account.invoice</field>
             <field name="view_mode">tree,form</field>
             <field name="domain">[('type','in',['out_invoice','out_refund'])]</field>
-            <field name="context">{'type':['out_invoice','out_refund'], 'journal_type': 'sale'}</field>
+            <field name="context">{'type':'out_invoice', 'journal_type': 'sale'}</field>
             <field name="search_view_id" ref="account.view_account_invoice_filter"/>
             <field name="help">We haven't sent you any invoice.</field>
         </record>