Merge lp:~openerp-dev/openobject-addons/7.0-opw-595298-fka into lp:openobject-addons/7.0
Proposed by
Foram Katharotiya (OpenERP)
Status: | Rejected |
---|---|
Rejected by: | Denis Ledoux (OpenERP) |
Proposed branch: | lp:~openerp-dev/openobject-addons/7.0-opw-595298-fka |
Merge into: | lp:openobject-addons/7.0 |
Diff against target: |
33 lines (+17/-1) 1 file modified
purchase/purchase.py (+17/-1) |
To merge this branch: | bzr merge lp:~openerp-dev/openobject-addons/7.0-opw-595298-fka |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stefan Rijnhart (Opener) (community) | Abstain | ||
Vinay Rana (OpenERP) | Pending | ||
Naresh(OpenERP) | Pending | ||
Review via email:
|
Description of the change
Hello,
I have fix the issue of the state of a purchase order always stay on approved state even if incoming shipment has been received and invoice has been paid when invoice method is set to the 'Based on purchase order lines' or 'Based on incoming shipment' in purchase order.
Thanks,
FKA
To post a comment you must log in.
Unmerged revisions
- 9531. By Foram Katharotiya (OpenERP)
-
[MERGE] with 7.0
- 9530. By Foram Katharotiya (OpenERP)
-
[IMP] add spaces
- 9529. By Foram Katharotiya (OpenERP)
-
[MERGE] with 7.0
- 9528. By Foram Katharotiya (OpenERP)
-
[MERGE] with 7.0
- 9527. By Foram Katharotiya (OpenERP)
-
[FIX] The state of a purchase order always stay on approved state even if incoming shipment has been received and invoice has been paid when invoice method is set to the 'Based on purchase order lines' or 'Based on incoming shipment' in purchase order
Hi Foram Katharotiya,
thank you very much for your work! I confirm that this patch fixes the problem, at least in my use case. According to code standards (PEP8), you would need to add some spaces to line 31, changing it from
purchase_ order_obj. write(cr, uid, po_id.id, {'state' :'done' }, context=context)
to
purchase_ order_obj. write(cr, uid, po_id.id, {'state': 'done'}, context=context)
Another space is missing in line 13, after 'shipped'. You may even want to consider writing "'shipped': True" instead of "'shipped': 1" as I believe the former is more standard.