Merge lp:~openerp-dev/openobject-addons/7.0-opw-593517-rha into lp:openobject-addons/7.0

Proposed by Rifakat Husen (OpenERP)
Status: Approved
Approved by: Naresh(OpenERP)
Approved revision: 9327
Proposed branch: lp:~openerp-dev/openobject-addons/7.0-opw-593517-rha
Merge into: lp:openobject-addons/7.0
Diff against target: 41 lines (+22/-0)
2 files modified
project/security/project_security.xml (+14/-0)
project_timesheet/security/project_timesheet_security.xml (+8/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/7.0-opw-593517-rha
Reviewer Review Type Date Requested Status
Rifakat Husen (OpenERP) (community) Disapprove
Naresh(OpenERP) (community) Approve
Review via email: mp+177361@code.launchpad.net

Description of the change

Added record rules for objects project.task.work and hr.analytic.timesheet
- Any user was able to see other's users' task work entry
- if there is already any task entry for any user then it is forbidden for another user to add his entry and it throws
  access warning.

Fix:
- user should be able to see his own task entry if he belongs to Project User group
- user should be able to see and modify all the entries if he belongs to Project Manager group

To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) :
review: Approve
Revision history for this message
Rifakat Husen (OpenERP) (rha-openerp) wrote :

We don't need this branch anymore, it's already been taken care from server 7.0,
Revision 5162, Revision ID: <email address hidden>

review: Disapprove

Unmerged revisions

9327. By Rifakat Husen (OpenERP)

[FIX] project, project_timesheet: added record rules for object task work,
- project user must not see task work entry of other users
- project manager should be able to see all the users' entry and able to modify it

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'project/security/project_security.xml'
2--- project/security/project_security.xml 2013-04-12 14:37:19 +0000
3+++ project/security/project_security.xml 2013-07-29 11:00:40 +0000
4@@ -95,5 +95,19 @@
5 <field name="groups" eval="[(4,ref('project.group_project_manager'))]"/>
6 </record>
7
8+ <record model="ir.rule" id="rule_project_user_task_work">
9+ <field name="name">Project User: Task Work</field>
10+ <field name="model_id" ref="model_project_task_work"/>
11+ <field name="domain_force">[('user_id', '=', user.id)]</field>
12+ <field name="groups" eval="[(4, ref('project.group_project_user'))]"/>
13+ </record>
14+
15+ <record model="ir.rule" id="rule_project_manager_task_work">
16+ <field name="name">Project Manager: Task Work</field>
17+ <field name="model_id" ref="model_project_task_work"/>
18+ <field name="domain_force">[(1, '=', 1)]</field>
19+ <field name="groups" eval="[(4, ref('project.group_project_manager'))]"/>
20+ </record>
21+
22 </data>
23 </openerp>
24
25=== modified file 'project_timesheet/security/project_timesheet_security.xml'
26--- project_timesheet/security/project_timesheet_security.xml 2012-06-25 12:30:34 +0000
27+++ project_timesheet/security/project_timesheet_security.xml 2013-07-29 11:00:40 +0000
28@@ -4,6 +4,14 @@
29 <record model="res.groups" id="base.group_user">
30 <field name="implied_ids" eval="[(4, ref('project.group_tasks_work_on_tasks'))]"/>
31 </record>
32+
33+ <record model="ir.rule" id="rule_project_manager_analytic_timesheet">
34+ <field name="name">Manager Project Analytic Timesheet</field>
35+ <field name="model_id" ref="hr_timesheet.model_hr_analytic_timesheet"/>
36+ <field name="domain_force">[(1, '=', 1)]</field>
37+ <field name="groups" eval="[(4, ref('project.group_project_manager'))]"/>
38+ </record>
39+
40 </data>
41 </openerp>
42