Merge lp:~openerp-dev/openobject-addons/7.0-opw-589937-ado into lp:openobject-addons/7.0

[Amit Dodiya (OpenERP)]

Hello,

"[IMP]account: displayed warning message while changing/adding fiscal position on invoice if invoice line is already created"

Issue:
While adding the fiscal position on invoice the tax mapping is not performed on existing invoice lines it only affects on new line created after adding fiscal position.

For version 7.0 i have implemented onchange method on fiscal position for displaying a message which triggers while changing/adding fiscal position on invoice if you have invoice line is already created in invoice.

Regards,
Amit Dodiya

[lp:~openerp-dev/openobject-addons/7.0-opw-589937-ado]

9025. By Amit Dodiya (OpenERP) on 2013-04-16

[IMP]account: displayed warning message while changing/adding fiscal position on invoice if invoice line is already created

[Naresh(OpenERP) (nch-openerp)]

review: Approve

Unmerged revisions

9025. By Amit Dodiya (OpenERP) on 2013-04-16

[IMP]account: displayed warning message while changing/adding fiscal position on invoice if invoice line is already created

=== modified file 'account/account_invoice.py'
--- account/account_invoice.py	2013-03-29 15:59:38 +0000
+++ account/account_invoice.py	2013-04-16 16:01:26 +0000
@@ -308,7 +308,13 @@
     ]
 
 
-
+    def onchange_fiscal_position(self, cr, uid, ids, fiscal_position_id, context):
+        if fiscal_position_id and ids:
+            invoice_line = self.pool.get('account.invoice.line').search(cr, uid, [('invoice_id', '=', ids[0])])
+            if invoice_line:
+                raise osv.except_osv(_('Warning!'), _('Be careful, We noticed change in fiscal position.' \
+                                                      'Lines are already created in invoice. If you want impact of this fiscal position you need to recreate the existing invoice lines !'))
+        return {'value': {'fiscal_position': fiscal_position_id}}
 
     def fields_view_get(self, cr, uid, view_id=None, view_type=False, context=None, toolbar=False, submenu=False):
         journal_obj = self.pool.get('account.journal')

=== modified file 'account/account_invoice_view.xml'
--- account/account_invoice_view.xml	2013-03-13 12:43:17 +0000
+++ account/account_invoice_view.xml	2013-04-16 16:01:26 +0000
@@ -167,7 +167,7 @@
                               on_change="onchange_partner_id(type,partner_id,date_invoice,payment_term, partner_bank_id,company_id)"
                               context="{'default_customer': 0, 'search_default_supplier': 1, 'default_supplier': 1}"
                               domain="[('supplier', '=', True)]"/>
-                            <field name="fiscal_position" widget="selection"/>
+                            <field name="fiscal_position" widget="selection" on_change="onchange_fiscal_position(fiscal_position, context)"/>
                             <field name="origin"/>
                             <field name="supplier_invoice_number"/>
                             <label for="reference_type"/>
@@ -321,7 +321,7 @@
                                 on_change="onchange_partner_id(type,partner_id,date_invoice,payment_term, partner_bank_id,company_id)"
                                 groups="base.group_user" context="{'search_default_customer':1, 'show_address': 1}"
                                 options='{"always_reload": True}'/>
-                            <field name="fiscal_position" widget="selection" />
+                            <field name="fiscal_position" widget="selection" on_change="onchange_fiscal_position(fiscal_position, context)"/>
                         </group>
                         <group>
                             <field name="date_invoice"/>