Merge lp:~openerp-dev/openobject-addons/7.0-opw-589810-rgo into lp:openobject-addons/7.0

[Ravi Gohil (OpenERP)]

Hi,

[FIX] point_of_sale: Return products from POS previous session should be linked to current opened session, if not found an active session then raise a warning message. (Maintenance Case: 589810)

For better understanding of this issue, please refer to the issue description of lp:1123575

I've fixed this issue by linking current opened session to the return product order and if there isn't any open session found then an appropriate warning message will be shown.

Kindly review the fix.

Thanks.

[Naresh(OpenERP) (nch-openerp)]

review: Approve

[Martin Trigaux (OpenERP) (mat-openerp)]

Hello,

I have merged this but changed a bit the code.
- Done inside the for loop
- Matching on the user instead of the pos (you may refund on another pos but wants the good salesman)
- Set the date to today

Regards

revno: 9393 [merge]
revision-id: <email address hidden>

=== modified file 'point_of_sale/point_of_sale.py'
--- point_of_sale/point_of_sale.py	2013-03-18 10:53:04 +0000
+++ point_of_sale/point_of_sale.py	2013-03-28 15:02:25 +0000
@@ -772,9 +772,14 @@
         """Create a copy of order  for refund order"""
         clone_list = []
         line_obj = self.pool.get('pos.order.line')
-        for order in self.browse(cr, uid, ids, context=context):
+        pos_orders = self.browse(cr, uid, ids, context=context)
+        current_session = self.pool.get('pos.session').search(cr, uid, [('config_id', '=', pos_orders[0].session_id.config_id.id), ('state', '!=', 'closed')])
+        if not current_session:
+            raise osv.except_osv(_('Error!'), _('To return product(s), you need to open a session that belongs to the same "Point of Sale" as of the product(s) to be returned.'))
+        for order in pos_orders:
             clone_id = self.copy(cr, uid, order.id, {
                 'name': order.name + ' REFUND',
+                'session_id': current_session[0]
             }, context=context)
             clone_list.append(clone_id)