Merge lp:~openerp-dev/openobject-addons/7.0-opw-587368-han into lp:openobject-addons/7.0

[Hardik Ansodariya (OpenERP)]

Fixed the issue of forcing delivery generated purchase order was validated by Admin only.

Steps to reproduce :

login : demo - demo
create sales order for customer agrolait
product : ADPT 20 PCS
Procurement method : ** ON ORDER **
Confirm Sale
View Delivery order
** Force Availability **
Deliver
----------------------------------------------------
Scheduler RUNS
---------------------------------------------------
Goto the purchase > Quotations
Confirm the Quotation

You get this warning ->

Operation forbidden !

Quantities, Units of Measure, Products and Locations cannot be modified on stock moves that have already been processed (except by the Administrator).

Now it will be validated by "Stock Manager" only.

With reference of maintenance case: 587368.

[Naresh(OpenERP) (nch-openerp)]

review: Approve

Unmerged revisions

9003. By Hardik Ansodariya (OpenERP) on 2013-04-15

[FIX] stock: when forcing delivery generated purchase order was only able to validated by admin user but not it will only validated by stock manager(Maintenance case: 587368)

=== modified file 'stock/stock.py'
--- stock/stock.py	2013-04-25 12:49:33 +0000
+++ stock/stock.py	2013-04-30 05:24:28 +0000
@@ -1767,13 +1767,15 @@
     def write(self, cr, uid, ids, vals, context=None):
         if isinstance(ids, (int, long)):
             ids = [ids]
-        if uid != 1:
+        data, data_id = self.pool.get('ir.model.data').get_object_reference(cr, uid, 'stock', 'group_stock_manager')
+        group_id_current_uid = self.pool.get('res.users').search(cr, uid, [('groups_id', '=', data_id)], context=context)
+        if uid not in group_id_current_uid:
             frozen_fields = set(['product_qty', 'product_uom', 'product_uos_qty', 'product_uos', 'location_id', 'location_dest_id', 'product_id'])
             for move in self.browse(cr, uid, ids, context=context):
                 if move.state == 'done':
                     if frozen_fields.intersection(vals):
                         raise osv.except_osv(_('Operation forbidden !'),
-                                             _('Quantities, Units of Measure, Products and Locations cannot be modified on stock moves that have already been processed (except by the Administrator).'))
+                                             _('Quantities, Units of Measure, Products and Locations cannot be modified on stock moves %s that have already been processed(except by the Stock Manager).') %(move.picking_id.name))
         return  super(stock_move, self).write(cr, uid, ids, vals, context=context)
 
     def copy(self, cr, uid, id, default=None, context=None):