Merge lp:~openerp-dev/openobject-addons/7.0-opw-586526-rgo into lp:openobject-addons/7.0

[Ravi Gohil (OpenERP)]

Hi,

Steps to reproduce issue:
1) Create a db with demo data and install point_of_sale module
2) Go to 'Point of Sale' menu and start new session and create few orders,
3) Go to sub-menu 'Orders' under 'Point of Sale' menu,
4) Return any product sold from the session started in step 2 using 'Return Products' wizard and pay for that returned product,
5) Now, go to sub-menu 'All Sessions' and try to close the session using 'Validate Closing and Post Entries' wizard,

You will notice warning message saying 'Wrong credit or debit value in accounting entry !'.

This error will be faced only if you have marked the boolean field 'Group Journal Items'(used to group the journal items by products) at 'Point of Sale/Configuration/Point of Sales'.

The root cause of the issue is in grouping logic, there are chances that the debit and credit both fields of account_move_line can have values, which will cause this kind of error.

This branch fixes this issue, kindly review the fix.

Thanks.

[lp:~openerp-dev/openobject-addons/7.0-opw-586526-rgo]

8839. By Fabien (Open ERP) on 2013-03-12

[FIX] misc fixes on contracts, timesheets

8840. By Antony Lesuisse (OpenERP) on 2013-03-12

[FIX] crm_partner_assign typos

8841. By Thibault Delavallée (OpenERP) on 2013-03-12

[FIX] sale: fixed typo in message, quotation send -> quotation sent.

8842. By Frederic van der Essen <email address hidden> on 2013-03-12

[FIX] point_of_sale: potentially improve performance when loading lots of categories

8843. By Denis Ledoux (OpenERP) on 2013-03-12

[FIX]crm: crm_lead, search view, group_by stage appeared twice

8844. By Antony Lesuisse (OpenERP) on 2013-03-12

[FIX] IE9 db creation, better monodb

8845. By Launchpad Translations on behalf of openerp on 2013-03-13

Launchpad automatic translations update.

8846. By Chris Biersbach (OpenERP) on 2013-03-13

[MERGE] OPW 589784: account: Removes the unnecessary 2nd cancel button on supplier invoices (this is handled by the caccount_cancel module)-

8847. By Thibault Delavallée (OpenERP) on 2013-03-13

[FIX] [IMP] Second batch of fixes and small usability fixes/improvements for CRM / mailing
email_template:
- fix email_template overriding recipients even when the template is void; the convention is that void values in the template are not used, meaning that they are not relevant in the template and not that they should erase existing values,
- added _order on name on email_template, in order to ease the choosing of templates,
crm:
- fix phonecall scheduling taking the lead/opportunity description as phonecall description,
- fix phonecall scheduling Chatter message: added phonecall description into it
- improved phonecall scheduling wizard form view (type is now on the left to ease reading and updating),
- fix opt_out parameter explanations; this parameter is relevant only for mass mailing and marketing campaigns,
- added 'Available for mass mailing' (opt_out = False) filter to give users the possibility of filtering leads before performing mass mailing,
res_partner:
- fix notification_email_send field missing on res_partner form view, preventing management of email reception policy for partners,
- fix opt_out parameter explanations (field added in email_template); this parameter is relevant only for mass mailing and marketing campaigns,
- added 'Available for mass mailing' (opt_out = False) filter to give users the possibility of filtering leads before performing mass mailing,
mail_message:
- fix read/unread filters on mail_message (help of both filters were the same; string of Unread becomes To Read to be clearer)

8848. By Thibault Delavallée (OpenERP) on 2013-03-13

[FIX] mail_mail: fixed search view group_by using fields removed between 6.1 and 7.0 (partner_id, user_id); added group_by author_id.

8849. By Quentin (OpenERP) <email address hidden> on 2013-03-13

[FIX] hr_expense now creates an account.move directly instead of a voucher. For legal issues, it was necessary to do this fix because it's not possible to put several taxes on a voucher line

8850. By Quentin (OpenERP) <email address hidden> on 2013-03-13

[FIX] analytic_contract, usability: display the reinvoicing info group when charge_expense is True

8851. By Quentin (OpenERP) <email address hidden> on 2013-03-13

[FIX] analytic_contract, usability: display the reinvoicing info group when charge_expense is True

8852. By Launchpad Translations on behalf of openerp on 2013-03-14

Launchpad automatic translations update.

8853. By Denis Ledoux (OpenERP) on 2013-03-14

[FIX]auth_signup: rewording reset password, which is not a reset password actually

8854. By Denis Ledoux (OpenERP) on 2013-03-14

[Revert]auth_signup: should be done here

8855. By Christophe Simonis (OpenERP) on 2013-03-14

[FIX] auth_signup: only automatically show signup if signup is enabled

8856. By Christophe Simonis (OpenERP) on 2013-03-14

[FIX] auth_signup: force password and login inputs to have a data-modes setted

8857. By Christophe Simonis (OpenERP) on 2013-03-14

[FIX] auth_openid: add data-modes attribute on <li> tags to be compatible with auth_signup module.
show()/hide() elements explicitly instead of setting a specific class for this job.

8858. By Christophe Simonis (OpenERP) on 2013-03-14

[FIX] auth_openid: use data-provider instead of title to match provider logo as title is translatable

8859. By Christophe Simonis (OpenERP) on 2013-03-14

[FIX] auth_openid: better design

8860. By Denis Ledoux (OpenERP) on 2013-03-14

[IMP]auth_signup: user state rewording

8861. By Denis Ledoux (OpenERP) on 2013-03-14

[FIX]portal_anonymous: set flag share to anonymous user

8862. By Chris Biersbach (OpenERP) on 2013-03-14

[MERGE] sale: adds id to the sale_order_line _order so that lines sty in the same order when the sale order is created. Patch by Peter langenberg / Agaplan

8863. By Quentin (OpenERP) <email address hidden> on 2013-03-14

[FIX] crm, usability: the button on lead form view should be used to log calls as on opportunities

8864. By Quentin (OpenERP) <email address hidden> on 2013-03-14

[FIX] account: removal of warnings at database creation due to unknown fields in account.payment.term.line model

8865. By Cedric Snauwaert (OpenERP) on 2013-03-14

[FIX]hr_timesheet_sheet: fix user_id variable referenced before assignment when no employee_id
specified in onchange_employee_id

8866. By Antony Lesuisse (OpenERP) on 2013-03-14

[MERGE] auth_signup res.users improve display of invitation and reset password

8867. By Antony Lesuisse (OpenERP) on 2013-03-15

[FIX] crm_partner_assign next review date in list

8868. By Antony Lesuisse (OpenERP) on 2013-03-15

[FIX] crm_partner_assign form use v7 groups

8869. By Launchpad Translations on behalf of openerp on 2013-03-15

Launchpad automatic translations update.

8870. By Quentin (OpenERP) <email address hidden> on 2013-03-15

[FIX] linkedin module compliancy with saas and https protocol

8871. By Quentin (OpenERP) <email address hidden> on 2013-03-15

[FIX] account_analytic_analysis, usability: removal of a default filter not wanted

8872. By Quentin (OpenERP) <email address hidden> on 2013-03-15

[FIX] account_payment: soft removal of buggy _amount_to_pay field, not needed as the field residual is making the trick most of the time

8873. By Launchpad Translations on behalf of openerp on 2013-03-16

Launchpad automatic translations update.

8874. By Launchpad Translations on behalf of openerp on 2013-03-17

Launchpad automatic translations update.

8875. By Launchpad Translations on behalf of openerp on 2013-03-18

Launchpad automatic translations update.

8876. By Quentin (OpenERP) <email address hidden> on 2013-03-15

[FIX] account: prevent the residual amount of invoices/credit notes to be negative

8877. By Quentin (OpenERP) <email address hidden> on 2013-03-18

[MERGE] crash when duplicating a pos_config

8878. By Quentin (OpenERP) <email address hidden> on 2013-03-18

[MERGE] sale: when printing the sale order report, do not print the discount column if user doesn't belong to the group that enables to see it

8879. By Quentin (OpenERP) <email address hidden> on 2013-03-18

[MERGE] removal of editable=top on stock.move tree view

8880. By Quentin (OpenERP) <email address hidden> on 2013-03-18

[FIX] account: fixed the filter used in manual reconciliation process

8881. By Launchpad Translations on behalf of openerp on 2013-03-19

Launchpad automatic translations update.

8882. By Chris Biersbach (OpenERP) on 2013-03-19

[MERGE] project_issue/mail_thread: Opening and closing date on project issues are now correctly set. Also improves the handling of the thread_model context value in mail_thread message_post

8883. By Quentin (OpenERP) <email address hidden> on 2013-03-19

[MERGE] analytic_contract_hr_expense: functional field computation fixed + added some helping info in hr_timesheet_invoice in the reinvoicing wizard

8884. By Quentin (OpenERP) <email address hidden> on 2013-03-19

[FIX] stock: if scrapping from a done stock move, use the destination location as the source for the scrapping move + [FIX] stock, mrp: restrict scrapping from virtual locations

8885. By Quentin (OpenERP) <email address hidden> on 2013-03-19

[REF] stock: code refactoring to follow PEP8 standards

8886. By Thibault Delavallée (OpenERP) on 2013-03-19

[MERGE] [FIX] mail: notification: do not send a notification email to partners having the same email address than the author, because of loops it may cause.

8887. By Fabien Meghazi (OpenERP) on 2013-03-19

[MERGE] Fix anonymous login flickering

8888. By Denis Ledoux (OpenERP) on 2013-03-19

[FIX]auth_signup: string concatenation now allowing action_id(integer) + able to redict to menu_id if no action given

8889. By Olivier Dony (Odoo) on 2013-03-19

[FIX] portal_anonymous: revert incorrect fix for login flickering, try another one that works in monodb mode

The previous fix at revision 8887 was not correct because start() did not call
 _super() in anonymous mode, while still depending on the value of
`self.selected_db`, that _super() is responsible for setting in monodb mode.
Multi-db mode was working fine.

8890. By Launchpad Translations on behalf of openerp on 2013-03-20

Launchpad automatic translations update.

8891. By Thibault Delavallée (OpenERP) on 2013-03-20

[FIX] mail: mail_create_nosubscribe context key also supported in message_post: allows to avoid subscribing the author to the document.

8892. By Thibault Delavallée (OpenERP) on 2013-03-20

[FIX] mail: mass mailing now does not push to followers; only to specific recipients. Improved tests for this update.

8893. By Quentin (OpenERP) <email address hidden> on 2013-03-20

[FIX] sale, sales analysis: fixed traceback when a line without product was present in the database.

8894. By Quentin (OpenERP) <email address hidden> on 2013-03-20

[FIX] account_analytic_analysis: don't set the group 'Mandatory use of templates in contracts' as part of the 'Sales' application, as it has the side effect of exploding the drop-down menu to manage access rights into booleans. This group belong to the base.module_category_hidden category

8895. By Quentin (OpenERP) <email address hidden> on 2013-03-20

[FIX] base_action_rule: no domain on user_id=False on filters because it pollutes the filters of everyone

8896. By van der Essen Frédéric (OpenERP) on 2013-03-20

[MERGE] point_of_sale: fix for a context=None related bug in the pos box wizard

8897. By Quentin (OpenERP) <email address hidden> on 2013-03-20

[FIX] account: improved tooltips and labels for manual reconciliation of accounting entries to be more explicit

8898. By Thibault Delavallée (OpenERP) on 2013-03-20

[MERGE] mail: fixes and improved tests
[FIX] mail_followers: notification emails did not have 'references' correctly filled with their parent message message_id,
[FIX] mail_mail: emails sent to partners now use the 'Name <email>' format for email_to, instead of just 'email'
[FIX] mail_compose_message: fixed mass_mail subscribing the author to all documents,
[FIX] mail_compose_message: fixed access rule on mail_compose_message not taking into account the wizard creation in mass_mail_mode (model but no res_id -> could lead to crash),
[TEST] mail: cleaned a bit the tests; mail gateways related tests are now in a dedicated file; tests were added that helped triggering the previous errors

8899. By Olivier Dony (Odoo) on 2013-03-20

[FIX] subscription: prevent lockup during cron job execution

Due to the way cron jobs are executed in multi-process
environments, the cron arbiter holds an exclusive lock
on the cron task row in the database.
During the course of the subscription cron jobs execution
they attempt to alter a record that has a FK towards
the cron task row, effectively deadlocking the whole
cron processing thread.
The fix is rather hackish: remove the explicit FK
constraint from the subscription model towards
ir.cron - this prevent PostgreSQL from requesting
an exclusive lock and triggering a deadlock.
This is only a temporary solution, the subscription
module should be rewritten for the next stable release.

8900. By Olivier Dony (Odoo) on 2013-03-20

[FIX] mail.alias: default alias generation now properly handles dots and emails; added tests

8901. By Launchpad Translations on behalf of openerp on 2013-03-21

Launchpad automatic translations update.

8902. By Thibault Delavallée (OpenERP) on 2013-03-21

[MERGE] [FIX] Chatter: fixed multiple click on 'send' creating multiple messages; fixed 'show more message' listing all new messages in flat mode.

8903. By Thibault Delavallée (OpenERP) on 2013-03-21

[MERGE] [FIX] portal with project_long_term access right and rules

A new module is added that make a bridge between Portal and Project Long Term.
It adds access rights and security rules allowing use project long term
along with portal.

8904. By Thibault Delavallée (OpenERP) on 2013-03-21

[MERGE] [FIX] mail: reply_to of sent notification emails is sanitized.

8905. By Denis Ledoux (OpenERP) on 2013-03-21

[FIX]l10n_be_coda: add statement id in bank statement line view to allow group by statement

8906. By Thibault Delavallée (OpenERP) on 2013-03-21

[MERGE] [FIX] mail_gateway: better algorithm to find the partner of an incoming email when having multiple matching partners for a given email address.

The mailgateway tries to find a partner that is also an user with the email_from.
If none is found, it takes the first partner with matching email.
In message_post, it tries to find the author based on the document's followers.
Indeed it is very likely that an answer comes from a follower of a document.

The whole process is not done inside the mailgateway because document
and followers related stuff belong to message_post, not to the mail gateway.

Tests have been added in mail.

8907. By Quentin (OpenERP) <email address hidden> on 2013-03-21

[MERGE] staging branch with fix in lunch (product preferences) and in sale (batch invoicing of sale orders)

8908. By Quentin (OpenERP) <email address hidden> on 2013-03-21

[FIX] mrp: there is no reason why selling a 'make_to_stock' product with phantom BOM should not explode the BOM (a 'make_to_order' product was already doing it, there is no reason to treat them differently)

8909. By Chris Biersbach (OpenERP) on 2013-03-21

[MERGE] Forwardport of 6.1 changes to project_issue working hours to open/close computations and corrections to the issue analysis report

8910. By Olivier Dony (Odoo) on 2013-03-21

[FIX] board: hide the "Add To Dashboard" option in search views when current action is incompatible (e.g. client actions don't work in dashboards at the moment)

8911. By Olivier Dony (Odoo) on 2013-03-21

[FIX] resource: fix test: use fixed start/end hours for work periods, otherwise the test breaks randomly depending on the hour of the day

8912. By Launchpad Translations on behalf of openerp on 2013-03-22

Launchpad automatic translations update.

8913. By Quentin (OpenERP) <email address hidden> on 2013-03-21

[FIX] account: fixed invoice analysis in multi-currency.

8914. By Quentin (OpenERP) <email address hidden> on 2013-03-22

[FIX] product: fixed inconsistancies between pricelist label and product form view + added some helping explanation

8915. By Quentin (OpenERP) <email address hidden> on 2013-03-22

[FIX] product: usability: added group on a label that must only be displayed when the related field is displayed

8916. By Quentin (OpenERP) <email address hidden> on 2013-03-22

[FIX] purchase, sale: purchase/account settings were unthicking automatically the field 'group_analytic_account_for_sales'

8917. By Thibault Delavallée (OpenERP) on 2013-03-22

[MERGE] [FIX] mail: message_process: do not process incoming emails
with a message_id already existing in database. Indeed loops can occur when
openerp send notification emails to partners having an email address
matching an alias. The mail was routed in the same thread, leading to
further notification emails sent, causing an email loop.

Before trying to find possible routes, check that the incoming email's
message_id is not already present in mail.message table.
If it is the case, return False.

Parsing of the message has been moved before routing, to avoid looking
for routes for emails we will discard.

8918. By Quentin (OpenERP) <email address hidden> on 2013-03-22

[FIX] account: manual reconciliation was not showing partners if the payment was encoded the same day than the last_reconciliation_date

8919. By Quentin (OpenERP) <email address hidden> on 2013-03-22

[FIX] hr_expense, project: Change domain in expense to support regular contracts + modified the type of parent project analytic account in order to hide it in this new domain (and because it is more logical with this 'view' type)

8920. By Antony Lesuisse (OpenERP) on 2013-03-22

[FIX] crm stages, rename test files
- if a lead is not yet assigned to a sale team show all the default stages
- rename test files

8921. By Launchpad Translations on behalf of openerp on 2013-03-23

Launchpad automatic translations update.

8922. By Launchpad Translations on behalf of openerp on 2013-03-24

Launchpad automatic translations update.

8923. By Launchpad Translations on behalf of openerp on 2013-03-25

Launchpad automatic translations update.

8924. By Quentin (OpenERP) <email address hidden> on 2013-03-25

[MERGE] fix of outlook plugin. It's now working with outlook 2010 (not yet with 2013, the work is still in progress for that version)

8925. By Thibault Delavallée (OpenERP) on 2013-03-25

[MERGE] [FIX] portal_sale: when confirming an invoice, no invitation emails should be sent.

8926. By Thibault Delavallée (OpenERP) on 2013-03-25

[MERGE] [FIX] [IMP] Portal: 'Portal' menu is renamed 'Billing and Support',
because this is basically what it will offer.

'To Do' mailbox is removed, to ease the use of messaging for portal
users. Setting a message as starred correctly sets the message as starred,
but do not move it into Todo. It stays in Inbox, with the star. The Todo
client action is kept for backwards compatibility, but menu entry is removed.

8927. By Olivier Dony (Odoo) on 2013-03-25

[FIX] crm: remove default read access on Leads/Phonecalls for Employee, this was necessary only for the History tab on Customers in 6.1

The History tab does not contain PhoneCalls and Leads/Opportunities
anymore in 7.0 - they have been replaced by buttons on the top of
the form.

8928. By Launchpad Translations on behalf of openerp on 2013-03-26

Launchpad automatic translations update.

8929. By Thibault Delavallée (OpenERP) on 2013-03-26

[MERGE] [FIX] product: fixed product unlink. When unlinking products, empty product templates were first unlinked, leading to products being deleted due to ondelete cascade. When unlinking the products, they were already deleted, leading to an access denied error when trying to delete the mail.message linked to the products. Now templates are unlinked after the products.

8930. By Chris Biersbach (OpenERP) on 2013-03-26

[MERGE] OPW: 586787 account: takes into account the ir_rules when listing the partners to reconcile

8931. By Chris Biersbach (OpenERP) on 2013-03-26

[MERGE] OPW 586921: mrp: upstream and downstream traceability now correctly display tree views instead of list views

8932. By Chris Biersbach (OpenERP) on 2013-03-26

[MERGE] OPW: 584197: account: Re-Opening periods from closed fiscal years is no longer allowed.

8933. By Quentin (OpenERP) <email address hidden> on 2013-03-26

[FIX] sale: invoicing several sale order lines in batch was not correctly working (only the first order was triggered and opened) + small refactoring

8934. By Quentin (OpenERP) <email address hidden> on 2013-03-26

[FIX] account: print invoice report shows now TIN instead of VAT (Openerp is supposed to be americanized)

8935. By Quentin (OpenERP) <email address hidden> on 2013-03-26

[FIX] account_analytic_analysis: wrong computation of remaining to invoice field (should not take into consideration lines for which it exists a draft invoice)

8936. By Launchpad Translations on behalf of openerp on 2013-03-27

Launchpad automatic translations update.

8937. By Quentin (OpenERP) <email address hidden> on 2013-03-27

[MERGE] account: updated 'print invoice report' sxw file accordingly to last version of rml

8938. By Olivier Dony (Odoo) on 2013-03-27

[FIX] document: make Documents first submenu, so FTP wizard does not open every time when document_ftp is installed

8939. By Christophe Matthieu (OpenERP) on 2013-03-27

[FIX] mail_followers: ellipsis for long name, esc name to display

8940. By van der Essen Frédéric (OpenERP) on 2013-03-27

[FIX] point_of_sale: clicking on the connection status should force sync

8941. By Thibault Delavallée (OpenERP) on 2013-03-27

[MERGE] [FIX] Chatter: when displaying a message title without subject, do not finish by a ':'.

8942. By Thibault Delavallée (OpenERP) on 2013-03-27

[MERGE] [FIX] mail_group: usability fix. The 'Wall view' of
mail groups now displays all messages (removed 'Unread' filter).
It also displays a composition box, not 'Send a message or Log a note'
as the purpose of a mail.group is to share with other members.

8943. By Thibault Delavallée (OpenERP) on 2013-03-27

[MERGE] [FIX] mail: now starring messages also sets them as unread.

8944. By Thibault Delavallée (OpenERP) on 2013-03-27

[MERGE] [FIX] Usability fix: when replying on a document, the wizard subject is Re: <doc_name>, not void.

8946. By Chris Biersbach (OpenERP) on 2013-03-27

[MERGE] fetchmail: The save_original parameter was not correctly apssed around, causing the original email to not be saved even if it was configured to be saved. This restores this functionality.

8947. By van der Essen Frédéric (OpenERP) on 2013-03-27

[FIX] point_of_sale: prevent from spinner to appear when we have a rpc timeout, and try to flush saved orders after loading

8948. By Quentin (OpenERP) <email address hidden> on 2013-03-27

[FIX] hr_expense: raised errors when an account is missing for the accounting entries generation

8949. By Quentin (OpenERP) <email address hidden> on 2013-03-27

[FIX] account: fixed missing context passing in account_invoice_refund wizard

8950. By Launchpad Translations on behalf of openerp on 2013-03-28

Launchpad automatic translations update.

8951. By Fabien Meghazi (OpenERP) on 2013-03-28

[IMP] Removed oauth auto-signin flicker. Also avoid xmlhttprequest error on redirection

8952. By Launchpad Translations on behalf of openerp on 2013-03-29

Launchpad automatic translations update.

8953. By Thibault Delavallée (OpenERP) on 2013-03-29

[MERGE] [REV] Partial revert of change introduced at rev 8926. Portal menu name is now Portal again, Billing and Support will be only used for sub-menus.

8954. By Thibault Delavallée (OpenERP) on 2013-03-29

[MERGE] [FIX] Chatter:
- message date was wrong for records created from incoming email servers.
- fix the (only visual) duplication of partners in the 'To' of quick reply widget
- fixed empty list message appearing twice when quickly clicking on 'read'

8955. By Denis Ledoux (OpenERP) on 2013-03-29

[FIX]crm: crm lead/opp merge, opportunities more important than lead. If lead.stage > opp.lead, the merged result will be the opp stage anyway.

8956. By Launchpad Translations on behalf of openerp on 2013-03-30

Launchpad automatic translations update.

8957. By Launchpad Translations on behalf of openerp on 2013-03-31

Launchpad automatic translations update.

8958. By Launchpad Translations on behalf of openerp on 2013-04-01

Launchpad automatic translations update.

8959. By Launchpad Translations on behalf of openerp on 2013-04-02

Launchpad automatic translations update.

8960. By Denis Ledoux (OpenERP) on 2013-04-02

[FIX]crm: crm lead/opp merge, when opp has stage with state cancel, then it is less important than leads with stage which are not in state cancel

8961. By Denis Ledoux (OpenERP) on 2013-04-02

[FIX]crm: crm lead/opp merge, if merged stage not in sales team and same type (lead/opp)n choose first stage of the sales team with the same type

8962. By Denis Ledoux (OpenERP) on 2013-04-02

[FIX]crm: crm lead/merge keystroke mistake, revert remove of minus

8963. By Thibault Delavallée (OpenERP) on 2013-04-03

[MERGE] [FIX] mail: private discussion now have correct recipients. After receiving messages, when clicking on reply button the recipients were correctly listed in the composer. However when sending the recipients were not correctly added, leading to a message considered as a log.

8964. By Christophe Matthieu (OpenERP) on 2013-04-03

[FIX] mail: issue: After receiving inbox messages from external emails, when clicking on reply button the external email is listed in the form. However when clicking on send the external email is removed! and instead of email what we get is an internal note.

8965. By Thibault Delavallée (OpenERP) on 2013-04-03

[FIX] Fixed wrong parameter name given to astimezone introduced at revision 8954; correct parameter name is tz, not tzinfo.

8966. By Thibault Delavallée (OpenERP) on 2013-04-03

[FIX] mail: notifications: email_to now contains reference to 'Followers of Doc Name' when having a related document.

8967. By Thibault Delavallée (OpenERP) on 2013-04-03

[FIX] mail: fixed recipients of private discussion, that were not correct. Author could be notified of their own reply independently of the specified recipients. Added tests for private discussions.

8968. By Thibault Delavallée (OpenERP) on 2013-04-03

[FIX] Chatter: do not show colon when there is no trailing record name.

8969. By Launchpad Translations on behalf of openerp on 2013-04-03

Launchpad automatic translations update.

8970. By Chris Biersbach (OpenERP) on 2013-04-04

[MERGE] OPW 587330: DO not copy the value of the statement_id field when copying an account move

8971. By Launchpad Translations on behalf of openerp on 2013-04-04

Launchpad automatic translations update.

8972. By Quentin (OpenERP) <email address hidden> on 2013-04-04

[MERGE] fixes in POS: optimizing the code when closing a session to have acceptable delays, used the right partner, changing the partner on the pos order also change it on the payment linked...

8973. By Quentin (OpenERP) <email address hidden> on 2013-04-04

[REF] sale_stock: removing of dead code and correction of documentation (process) linked to the invoicing after delivery of a sale order

8974. By Quentin (OpenERP) <email address hidden> on 2013-04-04

[REF] account: removal of useless code catching/hiding exceptions. Not needed

8975. By Quentin (OpenERP) <email address hidden> on 2013-04-04

[MERGE] base_calendar: fix in argument passing to get_recurrent_dates method (a list was needed, a string was passed)

8976. By Quentin (OpenERP) <email address hidden> on 2013-04-04

[FIX] hr_expense: was crashing if a tax without 'tax_collected_id' field was used at the time of accounting entries creation

8977. By Antony Lesuisse (OpenERP) on 2013-04-05

[FIX] base_calendar, lower cron frequency (around 0.003 hz)

8978. By Antony Lesuisse (OpenERP) on 2013-04-05

[IMP] fetchmail, on demand cron
enable a 3 micro hz cron only if needed as we want to lower the maximum
cron frequency in default addons to 1 micro hz

8979. By Antony Lesuisse (OpenERP) on 2013-04-05

[FIX] fetchmail, on demand cron, context test for date write

8980. By Launchpad Translations on behalf of openerp on 2013-04-05

Launchpad automatic translations update.

8981. By Thibault Delavallée (OpenERP) on 2013-04-03

[IMP] Chatter: improved footer of chatter messages: better differentiation of logged a note / send a message / system notification, with or without recipients.

8982. By Chris Biersbach (OpenERP) on 2013-04-05

[MERGE] OPW 590961: Unicode characters in product names no longer cause a traceback when generating the Stock Level Forecast report

8983. By Quentin (OpenERP) <email address hidden> on 2013-04-05

[MERGE] removal of wrong ir.rules testing unkown field 'message_follower_ids' on models that do not inherit mail.thread

8984. By Quentin (OpenERP) <email address hidden> on 2013-04-05

[MERGE] fix a crash when deleting an asset. Wrong model was referenced

8985. By Chris Biersbach (OpenERP) on 2013-04-05

[MERGE] OPW 590457: Cancelled procurements are no longer taken into account for the inventory analysis report

8986. By Quentin (OpenERP) <email address hidden> on 2013-04-05

[MERGE] better use of analytic distribution options on sale & purchase settings that now have an impact only on dedicated invoice view

8987. By Quentin (OpenERP) <email address hidden> on 2013-04-05

[MERGE] base_report_designer: Remove double . in numbered bulleted list

8988. By Quentin (OpenERP) <email address hidden> on 2013-04-05

[MERGE] procurement, fix of scheduler: there is no need to filter on product that can be pruchased only (we may need to re-stock some components (of BoM) that can't be purchased)

8989. By Olivier Dony (Odoo) on 2013-04-05

[MERGE] OPW 590221: sale_stock,purchase: fix timezone conversion error when scheduling delivery/procurement based on SO/PO date

The conversion code is duplicated in sale_stock and purchase
instead of being factored out in the fields.datetime class
because as of v7.0 users are able to selectively update
a single module without necessarily updating the base module
or the framework. This will be improved in next stable version.

8990. By Olivier Dony (Odoo) on 2013-04-05

[MERGE] OPW 590100: stock: fix stock.picking.in and stock.picking.out that did not apply stock.picking record rules in all cases

8991. By Quentin (OpenERP) <email address hidden> on 2013-04-05

[MERGE] crm: adding onchange on user_id field in opportunity form view in order to fill automatically the sales team

8992. By Denis Ledoux (OpenERP) on 2013-04-05

[FIX]base_import: get_fields now displays database id of the current model imported in normal fields

8993. By Denis Ledoux (OpenERP) on 2013-04-05

[REVERT]base_import: revert of last change, because break tests and needs review

8994. By Launchpad Translations on behalf of openerp on 2013-04-06

Launchpad automatic translations update.

8995. By Launchpad Translations on behalf of openerp on 2013-04-07

Launchpad automatic translations update.

8996. By Launchpad Translations on behalf of openerp on 2013-04-08

Launchpad automatic translations update.

8997. By Thibault Delavallée (OpenERP) on 2013-04-08

[FIX] mail: fixed some translation issues.
Document created text was not translatable
Subtype was fetched without context, therefore not translated
Removed odd override of _t introduced in mail_followers at revision 7885

8998. By Quentin (OpenERP) <email address hidden> on 2013-04-08

[MERGE] point_of_sale: prohibit the use of bank journal that aren't of type 'bank' or 'cash' as payment method in the pos

8999. By Launchpad Translations on behalf of openerp on 2013-04-09

Launchpad automatic translations update.

9000. By Quentin (OpenERP) <email address hidden> on 2013-04-09

[FIX] purchase, sale_stock: fix computation of date_planned when no timezone is defined for the user

9001. By Cedric Snauwaert (OpenERP) on 2013-04-09

[FIX]account_payment_report: formatlang expect float value not string

9002. By Launchpad Translations on behalf of openerp on 2013-04-10

Launchpad automatic translations update.

9003. By Quentin (OpenERP) <email address hidden> on 2013-04-10

[MERGE] hr & co, demo data: update of the pictures of employees

9004. By Quentin (OpenERP) <email address hidden> on 2013-04-10

[IMP] analytic: add the 'visibility tracking' on some fields in the chatter, to log when an important thing is changed

9005. By Quentin (OpenERP) <email address hidden> on 2013-04-10

[FIX] project_long_term: don't create the project twice if 'use_phases' is thicked.

9006. By Thibault Delavallée (OpenERP) on 2013-04-11

[MERGE] [FIX] mail: bettersuggested recipients based on email address. It tries to find a partner that is in the related document followers, or a user, or the first partner with matching email.

9007. By Thibault Delavallée (OpenERP) on 2013-04-11

[MERGE] [FIX] mail, email_template: fix attachment duplication and clean attachment management

The way attachments are linked to the document has been cleaned. Posting method message_post may receives 2 arguments:
- attachment_ids: those linked to the wizard model (mail.compose.message) are linked to the document (res_model, res_id)
- attachments: the tuples are used to create new attachments linked to the document
The wizard does not set the res_model and res_id of attachments anymore, delegating this job to message_post.

The mail.message and mail.compose.message now use their respective attachment_ids field when possible. This is done instead of reading/creating new attachments based on the attachments tuple each time a mail.compose.message is processed. Email templates now also use attachment_ids, in particular when generating emails, instead of using the attachments tuple. Only reports are still generated on the fly and put into attachments instead of attachment_ids.

A cron job has been added to unlink 'lost' attachments. Those are attachments:
- linked to 'mail.compose.message'
- with res_id=0 (due Chatter used in minimal mode or reports generated by templates before the wizard has an ID)
- with no activity for more than one day (create_date and write_date)

9008. By Thibault Delavallée (OpenERP) on 2013-04-11

[FIX] crm: fixed on_change_user that was crashing because
refers to a default_section_id field that is added in sale_crm bridge module.
New behavior is : one of the team user_id is a member (crm), or
default_section_id if defined or default behavior (sale_crm)

9009. By Launchpad Translations on behalf of openerp on 2013-04-11

Launchpad automatic translations update.

9010. By Antony Lesuisse (OpenERP) on 2013-04-11

[MERGE] point_of_sale fix tax rouding

9011. By Antony Lesuisse (OpenERP) on 2013-04-11

[FIX] point_of_sale fix tax rouding, this time tested, tnx fva

9012. By Launchpad Translations on behalf of openerp on 2013-04-12

Launchpad automatic translations update.

9013. By Launchpad Translations on behalf of openerp on 2013-04-13

Launchpad automatic translations update.

9014. By Launchpad Translations on behalf of openerp on 2013-04-14

Launchpad automatic translations update.

9015. By Launchpad Translations on behalf of openerp on 2013-04-15

Launchpad automatic translations update.

9016. By Thibault Delavallée (OpenERP) on 2013-04-15

[MERGE] [FIX] [ADD] project, project_issue, portal_project, portal_project_issue: improved privacy_visibility selection of project.project; improved access rules; added tests to enforce them.

project: privacy_visibility now has basically 'public', 'employees' and 'followers' possible values.
portal_project: add 'portal' to the privacy_visibility values
- public: everybody see the project and all tasks
- portal: employees see the project and all tasks; portal users see the project and the followed or assigned tasks
- employees: employees see the project and all tasks
- followers: employees see the project if follower and the follower or assigned tasks

portal_project, portal_project_issue: added tests for access rights

9017. By Quentin (OpenERP) <email address hidden> on 2013-04-15

[FIX] l10n_be_coda: fixed a glitch in the coda import when the starting balance of the statement is negative. Courtesy of Damien Carlier (Idealis Consulting)

9018. By Quentin (OpenERP) <email address hidden> on 2013-04-15

[FIX] l10n_be: removal of useless mapping rule of accounts in 'nationale' fiscal position

9019. By Quentin (OpenERP) <email address hidden> on 2013-04-15

[FIX] hr: typo in welcome message + [IMP] hr_holidays: better message when a constraint is fired

9020. By Quentin (OpenERP) <email address hidden> on 2013-04-15

[MERGE] hr_recruitment: removal of group 'no one' on create_date field in tree view

9021. By Thibault Delavallée (OpenERP) on 2013-04-15

[FIX] project_issue, project_phase: fixed access rights on anonymous.

9022. By Launchpad Translations on behalf of openerp on 2013-04-16

Launchpad automatic translations update.

9023. By Stephane Wirtel (OpenERP) on 2013-04-16

[MERGE] accounts: Load the charts of account from Apps whether those are not in
the local addons path.

9024. By Christophe Simonis (OpenERP) on 2013-04-16

[MERGE] [FIX] mail: mail composer: Use a text field instead of a html field

html fields are sanitized just before saving data into the database.
In the composer, this cause the sanitization of the templated
message (for mass mailing messages) before the rendering, forbidding
the use of templated html links.
The html of the message is sanitized by message_post()

9025. By Launchpad Translations on behalf of openerp on 2013-04-17

Launchpad automatic translations update.

9026. By Olivier Dony (Odoo) on 2013-04-17

[MERGE] auth_signup: upon signup of new user, the company_id[s] of the corresponding partner must be used

The default was to use those of the template user,
which may not be correct in multi-company cases.

9027. By Olivier Dony (Odoo) on 2013-04-17

[REVERT] mail: undo model-level change that can cause issue for stable deployments

Failing to force a manual update of the mail module would cause
all composer wizards to display html contents without the WYSIWYG
editor, making it mostly unusable for regular users. Users are
not expected to always force an update of all modules after
updating to the latest source code.

9028. By Quentin (OpenERP) <email address hidden> on 2013-04-17

[IMP] crm: log a meeting now calls message_post and writes the meeting information in the chatter

9029. By Quentin (OpenERP) <email address hidden> on 2013-04-17

[FIX] purchase, usability: removed default search that was hiding the RFQ's Sent

9030. By Stephane Wirtel (OpenERP) on 2013-04-17

[FIX] account: avoid a crash if the user does not select an existing chart.

9031. By Launchpad Translations on behalf of openerp on 2013-04-18

Launchpad automatic translations update.

9032. By Olivier Dony (Odoo) on 2013-04-17

[FIX] stock, multicompany: avoid crashing when computing inventory levels and no warehouse/locations exists for a company

This is a cherry-pick backport of the trunk fix for bug 921561,
originally merged in trunk at revid <email address hidden>

9033. By Quentin (OpenERP) <email address hidden> on 2013-04-18

[FIX] account* modules: added 'account_period_prefer_normal':True in context when trying to find the period related to a date.

This patch will be forward ported in trunk by changing the behaviour of account_period.find() in order to fetch the normal periods by default (account_period_prefer_normal will be True by default) because there are no business case i could think of where you'd like to get the opening period (except in the closure but it's held in a different way there). On the other hand, it's pretty easy to forget to put that key in the context and introduce a new bug that will select the opening period instead of the wanted one

9034. By Quentin (OpenERP) <email address hidden> on 2013-04-18

[FIX] account, account.move.line form view: the same method was defined twice, differently, and parameters were not correctly passed in onchanges

9035. By Quentin (OpenERP) <email address hidden> on 2013-04-18

[FIX] hr_expense, usability: added sum in tree view

9036. By Quentin (OpenERP) <email address hidden> on 2013-04-18

[MERGE][FIX] product: context propagating in res_currency.compute(). Courtesy of Yannick Vaucher @ Camptocamp. Thanks dude

9037. By Nicolas Vanhoren (OpenERP) on 2013-04-18

[FIX] account: minor javascript problem that made appear a stack trace

9038. By Quentin (OpenERP) <email address hidden> on 2013-04-18

[FIX] sale: fix in the workflow of the sale order that appeared on invoice deletion

9039. By Olivier Dony (Odoo) on 2013-04-18

[FIX] sale: orders/quotations action should not force `display_address` flag

Doing so affects autocompletion of search results, etc.
while the fields on the form view are already properly
displayed anyway.

9040. By Launchpad Translations on behalf of openerp on 2013-04-19

Launchpad automatic translations update.

9041. By Nicolas Vanhoren (OpenERP) on 2013-04-19

[FIX] pad: problem about pad title not being updated correctly, was solved by solving another, more serious, bug that didn't updated correctly the database backup of the pad

9042. By Nicolas Vanhoren (OpenERP) on 2013-04-19

[FIX] pad: revert part of previous fix because it could produce problems in some cases

9043. By Olivier Dony (Odoo) on 2013-04-20

[MERGE/ADD] Many important fixes for contact/company management + new module account_report_company

This patch comes with a corresponding server-side patch (revision 4946 revid: <email address hidden>)

- module-specific overrides of _commercial_fields() for all modules adding accounting/invoicing-related fields to res.partner

- corresponding changes to inherited views of res.partner form to hide these commercial fields when they are in fact "related fields" of their parent commercial entity. This mainly concerns 2 sections of the Partner form: the whole Accounting tab, and the bottom of the Sales&Purchase tabs with the pricelists and invoicing fields. These sections are replaced by a short message and a button to open the commercial entity to view/edit the fields

- a few fixes to properly delegate the resolution of various contact/address types to the corrected res.partner.address_get()

- changes to search views of the main business documents so that searching for a company name will also match its contacts

- a fix of the _find_accounting_partner() method that the account module uses to locate the partner to which journal entries must be linked - it will now use the same semantics as for "commercial entity"

- fix issue detected by Joël Grand-Guillaume in comment #34 of bug 1160365: when invoicing after delivery, the invoicing contact/address must be used rather than the main customer. Tests updated accordingly.

- add new 7.0 module "account_report_company": this module adds an extra stored field "commercial_partner_id" on Invoices to make reporting/aggregating by partner easier in the Invoice list and in the Invoice Analysis report. This module is expected to be merged in the main account module in the next major release. The module can be installed without any risk on any existing 7.0 databases.
This module also mitigates group_by issues on all models by adding a new stored function field `display_name` on res.partner that contains the name_get() result in the form "ACME, John Doe" and set it as the default _order for res.partner. This ensures that group_by entries for the same company will always be next to each other on all documents: "ACME" is directly followed by "ACME, John Doe", "ACME, John Anderson", etc. This field also replaces the `name` field in the list and kanban views of Partners, so that the display order matches the display labels.

- fixed unique constraints definition on some commercial fields on res.partner (l10n_ro)

9044. By Launchpad Translations on behalf of openerp on 2013-04-20

Launchpad automatic translations update.

9045. By Launchpad Translations on behalf of openerp on 2013-04-21

Launchpad automatic translations update.

9046. By Christophe Matthieu (OpenERP) on 2013-04-22

[FIX] web_linkedin: display the real linkedin error inside the openerp popup.

9047. By Thibault Delavallée (OpenERP) on 2013-04-17

[FIX] mail, crm: fixed some access rights issues when using chatter on a document without access rights with portal users.

9048. By Thibault Delavallée (OpenERP) on 2013-04-16

[FIX] project: default visibility is employees only. Updated demo data by the way.

9049. By Ravi Gohil (OpenERP) on 2013-04-22

[FIX] point_of_sale: When we try to close a session which has a return product entry, you will face warning saying 'Wrong credit or debit value in accounting entry' and you wont be able close the session. (Maintenance Case: 586526)

[Naresh(OpenERP) (nch-openerp)]

review: Approve

[Martin Trigaux (OpenERP) (mat-openerp)]

Hello Ravi,

If your analysis of the problem is correct (wrong key), I think your solution is a bit over-complicated. If fixed this for another opw in the commit 9269 (rev-id: <email address hidden>).
I will then reject this branch.

Regards

Unmerged revisions

9049. By Ravi Gohil (OpenERP) on 2013-04-22

[FIX] point_of_sale: When we try to close a session which has a return product entry, you will face warning saying 'Wrong credit or debit value in accounting entry' and you wont be able close the session. (Maintenance Case: 586526)

=== modified file 'point_of_sale/point_of_sale.py'
--- point_of_sale/point_of_sale.py	2013-04-18 10:24:33 +0000
+++ point_of_sale/point_of_sale.py	2013-04-22 09:58:31 +0000
@@ -956,7 +956,7 @@
                     'journal_id': order.sale_journal.id,
                 }, context=context)
 
-            def insert_data(data_type, values):
+            def insert_data(data_type, values, is_return=False):
                 # if have_to_group_by:
 
                 sale_journal_id = order.sale_journal.id
@@ -973,11 +973,11 @@
                 })
 
                 if data_type == 'product':
-                    key = ('product', values['partner_id'], values['product_id'])
+                    key = ('product', values['partner_id'], values['product_id'], is_return)
                 elif data_type == 'tax':
-                    key = ('tax', values['partner_id'], values['tax_code_id'],)
+                    key = ('tax', values['partner_id'], values['tax_code_id'], is_return,)
                 elif data_type == 'counter_part':
-                    key = ('counter_part', values['partner_id'], values['account_id'])
+                    key = ('counter_part', values['partner_id'], values['account_id'], is_return)
                 else:
                     return
 
@@ -1054,7 +1054,7 @@
                     'tax_code_id': tax_code_id,
                     'tax_amount': tax_amount,
                     'partner_id': order.partner_id and self.pool.get("res.partner")._find_accounting_partner(order.partner_id).id or False
-                })
+                }, True if amount<0 else False)
 
                 # For each remaining tax with a code, whe create a move line
                 for tax in computed_taxes:
@@ -1072,7 +1072,7 @@
                         'tax_code_id': tax_code_id,
                         'tax_amount': tax_amount,
                         'partner_id': order.partner_id and self.pool.get("res.partner")._find_accounting_partner(order.partner_id).id or False
-                    })
+                    }, True if amount<0 else False)
 
             # Create a move for each tax group
             (tax_code_pos, base_code_pos, account_pos, tax_id)= (0, 1, 2, 3)
@@ -1089,7 +1089,7 @@
                     'tax_code_id': key[tax_code_pos],
                     'tax_amount': tax_amount,
                     'partner_id': order.partner_id and self.pool.get("res.partner")._find_accounting_partner(order.partner_id).id or False
-                })
+                }, True if tax_amount<0 else False)
 
             # counterpart
             insert_data('counter_part', {
@@ -1098,7 +1098,7 @@
                 'credit': ((order.amount_total < 0) and -order.amount_total) or 0.0,
                 'debit': ((order.amount_total > 0) and order.amount_total) or 0.0,
                 'partner_id': order.partner_id and self.pool.get("res.partner")._find_accounting_partner(order.partner_id).id or False
-            })
+            }, True if order.amount_total<0 else False)
 
             order.write({'state':'done', 'account_move': move_id})