Merge lp:~openerp-dev/openobject-addons/7.0-opw-584224-rgo into lp:openobject-addons/7.0
Status: | Needs review |
---|---|
Proposed branch: | lp:~openerp-dev/openobject-addons/7.0-opw-584224-rgo |
Merge into: | lp:openobject-addons/7.0 |
Diff against target: |
68 lines (+36/-0) 2 files modified
base_action_rule/base_action_rule.py (+34/-0) base_action_rule/tests/base_action_rule_test.py (+2/-0) |
To merge this branch: | bzr merge lp:~openerp-dev/openobject-addons/7.0-opw-584224-rgo |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
nel | Pending | ||
Review via email: mp+144120@code.launchpad.net |
Description of the change
This branch contains fix for below 2 issues:
Issue 1:
Example: User A has created and saved a filter on crm.lead object and shared with all users, hence, it will be available to all users.
Now, user B will log in and thinks that this filter doesn't belong to me, he will find the user who creates it and assign that user to that filter from menu Setting/
So, I fixed this issue by introducing a python constraint which will denied user to do so if the filter is used in action rules(as action rules can have filters which are global).
Issue 2:
One is able to assign a user by clicking on "Create and Edit" on filter fields(m2o fields at Setting/
Here too, I introduce the python constraints which will restrict users to do so.
Kindly review the fix and share your views on this fix.
Thanks.
Unmerged revisions
- 8594. By Ravi Gohil (OpenERP)
-
[FIX] base_action_rule: 'Automated Actions' should only select filters which are shared with all users (global filters only) in 'Before Update Filter/After Update Filter' fields and the filters which are used in 'Automated Actions' shouldn't be allowed to assign a user: (Maintenance Case: 584224)