Merge lp:~openerp-dev/openobject-addons/7.0-bug-1172149-cga into lp:openobject-addons/7.0

Proposed by Lorenzo Battistini
Status: Merged
Merged at revision: 9620
Proposed branch: lp:~openerp-dev/openobject-addons/7.0-bug-1172149-cga
Merge into: lp:openobject-addons/7.0
Diff against target: 11 lines (+1/-1)
1 file modified
project/project_data.xml (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/7.0-bug-1172149-cga
Reviewer Review Type Date Requested Status
Martin Trigaux (OpenERP) (community) Approve
Alex Comba - Agile BG (community) Approve
Review via email: mp+195248@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alex Comba - Agile BG (tafaru) :
review: Approve
Revision history for this message
Martin Trigaux (OpenERP) (mat-openerp) wrote :

Thanks for your patch, merged in 7.0.
I have just changed the patch to exclude the mail.message.subtype data as we want it to be overwritten with update.

revno: 9620 [merge]
revision-id: <email address hidden>

review: Approve
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

@Martin, thanks for the merge. Just wanted to ask you if you are certain about the mail.message.subtype, as this is one of the things that I checked for the OCB-review of this patch. Mail.message.subtype data is noupdate in most cases. I just checked a couple of modules: the records are added with noupdate='1' in account_voucher, crm, mail, hr_expense, event, hr_holidays, hr_recruitement, purchase, analytic, sale, sale_crm, project_issue. Only one I found without noupdate is in the project module.

Revision history for this message
Martin Trigaux (OpenERP) (mat-openerp) wrote :

Hi Stefan,

Thanks for the remark, I explained the reason on the bug report

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'project/project_data.xml'
2--- project/project_data.xml 2013-03-21 16:29:39 +0000
3+++ project/project_data.xml 2013-11-14 15:54:44 +0000
4@@ -1,6 +1,6 @@
5 <?xml version="1.0" encoding="utf-8"?>
6 <openerp>
7- <data>
8+ <data noupdate="1">
9 <!-- This will set the unit of measure used in projects and tasks.-->
10 <record id="base.main_company" model="res.company">
11 <field name="project_time_mode_id" ref="product.product_uom_hour"></field>