Merge lp:~openerp-dev/openobject-addons/7.0-bug-1098226-bth into lp:openobject-addons/7.0

[Bhumi Thakkar (Open ERP)]

Hello,

       Fixed: config_id problem with pos session

To Reproduce:
1. Create 1 user and give access rights as a user in pos.
2. Login as a new created user and click on pos menu.
3. If any other user have not closed his/her session then logged user get 2 buttons [start selling and close session] else get 1 button of New Session.
4. Click on button Start Selling.

Observed: Error of could not read property 'config_id'.
Expected: User can use not used session. could start selling or closed on another user's session (must not use another users' session). As we have to create session for each user.

Thanks.

[Martin Trigaux (OpenERP) (mat-openerp)]

Hello,

Thanks for the patch.
I don't believe you need to change the error message, it's explicit enough (moreover it is grammatically correct).
The change in pos_session_opening.py is correct on the other hand.
Merged into addons 7.0 at revision 9255

=== modified file 'point_of_sale/point_of_sale.py'
--- point_of_sale/point_of_sale.py	2012-12-06 14:56:32 +0000
+++ point_of_sale/point_of_sale.py	2013-01-17 12:08:40 +0000
@@ -290,7 +290,7 @@
 
     _constraints = [
         (_check_unicity, "You cannot create two active sessions with the same responsible!", ['user_id', 'state']),
-        (_check_pos_config, "You cannot create two active sessions related to the same point of sale!", ['config_id']),
+        (_check_pos_config, "You cannot create two active sessions related to the same point of sale! Use not used point of sale", ['config_id']),
     ]
 
     def create(self, cr, uid, values, context=None):

=== modified file 'point_of_sale/wizard/pos_session_opening.py'
--- point_of_sale/wizard/pos_session_opening.py	2012-12-06 14:56:32 +0000
+++ point_of_sale/wizard/pos_session_opening.py	2013-01-17 12:08:40 +0000
@@ -88,6 +88,7 @@
         session_ids = proxy.search(cr, uid, [
             ('state', '!=', 'closed'),
             ('config_id', '=', config_id),
+            ('user_id', '=', uid),
         ], context=context)
         if session_ids:
             session = proxy.browse(cr, uid, session_ids[0], context=context)