Merge lp:~openerp-dev/openobject-addons/7.0-595797-opw-skh into lp:openobject-addons/7.0

Proposed by Somesh Khare
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/7.0-595797-opw-skh
Merge into: lp:openobject-addons/7.0
Diff against target: 13 lines (+2/-1)
1 file modified
l10n_be_coda/wizard/account_coda_import.py (+2/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/7.0-595797-opw-skh
Reviewer Review Type Date Requested Status
Houssine (community) Approve
Anaël Closson (openerp) Pending
Naresh(OpenERP) Pending
Review via email: mp+180852@code.launchpad.net

Description of the change

Hello Sir,

[Fix]:l10n_be_coda :structured communication get truncate with address

Problem:
while parsing the coda file you can have to type of communication :

- structured communication
- free communication

Import of coda file will concatenate the partner address with the structured communication(If any) in the created statement line, Please check the bug: https://bugs.launchpad.net/openobject-addons/+bug/1204545 for more information on this.

Thanks & Regards,
Somesh Khare

To post a comment you must log in.
Revision history for this message
Houssine (houssine-bakkali) wrote :

it solves the related bug

review: Approve

Unmerged revisions

9359. By Somesh Khare(OpenERP) <email address hidden>

[FIX] l10n_be_coda :structured communication get truncate with address(Case: Ref 595797)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'l10n_be_coda/wizard/account_coda_import.py'
2--- l10n_be_coda/wizard/account_coda_import.py 2013-06-20 14:17:51 +0000
3+++ l10n_be_coda/wizard/account_coda_import.py 2013-08-19 12:03:51 +0000
4@@ -199,7 +199,8 @@
5 statement['lines'][-1]['counterpartyNumber'] = rmspaces(line[10:44])
6 statement['lines'][-1]['counterpartyCurrency'] = rmspaces(line[44:47])
7 statement['lines'][-1]['counterpartyName'] = rmspaces(line[47:82])
8- statement['lines'][-1]['communication'] += rmspaces(line[82:125])
9+ if statement['lines'][-1]['communication_struct'] == False :
10+ statement['lines'][-1]['communication'] += rmspaces(line[82:125])
11 else:
12 # movement data record 2.x (x != 1,2,3)
13 raise osv.except_osv(_('Error') + 'R2006', _('\nMovement data records of type 2.%s are not supported ') % line[1])