Merge lp:~openerp-dev/openobject-addons/7.0-595240-opw-skh into lp:openobject-addons/7.0

Proposed by Somesh Khare
Status: Approved
Approved by: Naresh(OpenERP)
Approved revision: 9312
Proposed branch: lp:~openerp-dev/openobject-addons/7.0-595240-opw-skh
Merge into: lp:openobject-addons/7.0
Diff against target: 13 lines (+1/-2)
1 file modified
delivery/sale.py (+1/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/7.0-595240-opw-skh
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Approve
Review via email: mp+180790@code.launchpad.net

Description of the change

Hello Sir,

[FIX]Delivery: carrier information not propagated from sale order to pickings.

Steps To reproduce:
1. Install Delivery module.
2. Create a Sale Order and add the carrier information in the Sale Order, after clicking on "Add in Quote" button (See Carrier information becomes blank)
3. Now confirm the Sale Order and see the carrier information on the created "Delivery Order" (No carrier information).

You can also see the bug: https://bugs.launchpad.net/openobject-addons/+bug/1192115 for more information. Root of the problem is line 76 in delivery/sale.py where def delivery_set() method make the carrier_id as False.

This branch fixes this issue. Kindly review the branch and please share your view.

Thanks & Regards,
Somesh Khare

To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) :
review: Approve

Unmerged revisions

9312. By Somesh Khare(OpenERP) <email address hidden>

[FIX]Delivery: carrier information not propagated from sale order to pickings (Case: ref 595240)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'delivery/sale.py'
2--- delivery/sale.py 2013-06-07 11:38:29 +0000
3+++ delivery/sale.py 2013-08-19 07:06:56 +0000
4@@ -72,8 +72,7 @@
5 'tax_id': [(6,0,taxes_ids)],
6 'type': 'make_to_stock'
7 })
8- #remove the value of the carrier_id field on the sale order
9- return self.write(cr, uid, ids, {'carrier_id': False}, context=context)
10+ return True
11 #return {'type': 'ir.actions.act_window_close'} action reload?
12
13 sale_order()