Merge lp:~openerp-dev/openobject-addons/7.0-595239-opw-skh into lp:openobject-addons/7.0

Proposed by Somesh Khare
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/7.0-595239-opw-skh
Merge into: lp:openobject-addons/7.0
Diff against target: 16 lines (+6/-0)
1 file modified
delivery/stock.py (+6/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/7.0-595239-opw-skh
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp (community) Disapprove
Naresh(OpenERP) Pending
Review via email: mp+190937@code.launchpad.net

Description of the change

Hello Sir,

[FIX]delivery: delivery - partial delivery will copy tracking number in the backorder picking.

Steps to reproduce this issue,
1. connect to runbot
2. go to Warehouse -> delivery orders
3. select OUT/001
4. force availability of the picking
5. edit the picking, set a carrier tracking number of Z1234
6. Make a partial delivery, with only 1 EXT-HDD

Expected result:

* the OUT/001 picking should have the tracking number Z1234, and be in state Delivered
* the OUT/xxxx picking, backorder of OUT/001 should be in state "ready to deliver" and have a blank tracking number

Actual result:

* the backorder of OUT/001 has the Z1234 tracking number

This branch fixes this issue.Kindly review the branch and share your views.

Thanks,
Somesh Khare

To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :
review: Disapprove

Unmerged revisions

9332. By Somesh Khare(OpenERP) <email address hidden>

[FIX]delivery: delivery - partial delivery will copy tracking number in the backorder picking (Case: ref 595239)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'delivery/stock.py'
2--- delivery/stock.py 2012-12-18 08:59:14 +0000
3+++ delivery/stock.py 2013-10-14 12:28:43 +0000
4@@ -51,6 +51,12 @@
5 result[line.picking_id.id] = True
6 return result.keys()
7
8+ def write(self, cr, uid, ids, vals, context=None):
9+ if context is None: context = {}
10+ if vals.get('backorder_id'):
11+ vals.update(carrier_tracking_ref = '')
12+ return super(stock_picking, self).write(cr, uid, ids, vals, context=context)
13+
14 _columns = {
15 'carrier_id':fields.many2one("delivery.carrier","Carrier"),
16 'volume': fields.float('Volume'),