Merge lp:~openerp-dev/openobject-addons/7.0-590717-opw-skh into lp:openobject-addons/7.0

[Somesh Khare]

Hello Sir,

[FIX]account_payment: Page not refresh when select invoices into the payment Order.

Steps:
1. Install account_payment module.
2. Create a payment Order and select invoices to pay using button "Select Invoices to pay".
3. Page will not refersh when you selected the invoices, Where by refershing the web page you can see the invoices into the Order.

This branch fixes this issue. Kindly review the branch and please share your views on it.

Thanks & Regards,
Somesh Khare

[Naresh(OpenERP) (nch-openerp)]

review: Approve

[Naresh(OpenERP) (nch-openerp)]

may be web should reload when ir.actions.act_window_close

[Stéphane Bidoul (Acsone) (sbi)]

Hello,

IMHO, this fix is not appropriate. In some tests it completely reloaded the page, while in others, I believe it did nothing.

Moreover, a similar wizard to import invoices in bank statements does not completely refresh the page (only the list with statement lines is refreshed), which makes me belive the proper fix must be something else.

Best regards,

-sbi

review: Needs Fixing (code review and test)

[Naresh(OpenERP) (nch-openerp)]

Hi Stephane,

Absolutely right ! This needs to be fixed from web itself, web should reload when it finishes ir.actions.act_window_close action.

Thanks,
Naresh

Unmerged revisions

8999. By Somesh Khare on 2013-04-09

[FIX]account_payment: Page not refresh when select invoices into the payment Order (Case: ref 590717)

=== modified file 'account_payment/wizard/account_payment_order.py'
--- account_payment/wizard/account_payment_order.py	2012-12-06 14:56:32 +0000
+++ account_payment/wizard/account_payment_order.py	2013-04-09 06:41:22 +0000
@@ -90,7 +90,7 @@
                     'date': date_to_pay,
                     'currency': (line.invoice and line.invoice.currency_id.id) or line.journal_id.currency.id or line.journal_id.company_id.currency_id.id,
                 }, context=context)
-        return {'type': 'ir.actions.act_window_close'}
+        return {'type': 'ir.actions.client', 'tag': 'reload',}
 
     def search_entries(self, cr, uid, ids, context=None):
         line_obj = self.pool.get('account.move.line')