Merge lp:~openerp-dev/openobject-addons/6.1-opw-584908-ado into lp:openobject-addons/6.1

Proposed by Amit Dodiya (OpenERP)
Status: Rejected
Rejected by: Xavier ALT
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-584908-ado
Merge into: lp:openobject-addons/6.1
Diff against target: 21 lines (+2/-2)
1 file modified
fetchmail/fetchmail.py (+2/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-584908-ado
Reviewer Review Type Date Requested Status
Xavier ALT (community) Disapprove
Naresh(OpenERP) Pending
Review via email: mp+147610@code.launchpad.net

Description of the change

Hello,

"[FIX] smtp_server fix for identifying the correct smtp server for a incoming mail server while sending mail using server action"

Issue:
When we set auto-reply(through server action) for any incoming mail the auto-reply(server action) should sent mail from the same user outgoing server from which it's fetched.

Steps:
1). Configure one incoming mail server(e.g: <email address hidden>)
2). Configure two outgoing mail server(e.g: <email address hidden>, <email address hidden>)
3). One Server actions is configured of type = email to send auto reply to incoming mail
4). And set the above server action in incoming mail server(<email address hidden>)

Now when you send mail on <email address hidden> in auto reply you will get reply from <email address hidden> instead of <email address hidden> because the system is always take the first outgoing server instead of finding same like configured in incoming mail server.

The solution contains two side fix server and addons.
The server side fix for this issue is : lp:~openerp-dev/openobject-server/6.1-opw-584908-ado

Regards,
Amit Dodiya

To post a comment you must log in.
Revision history for this message
Xavier ALT (dex-phx) wrote :

Hi,

As discussed on the OPW ticket - the original problem can easily be solved by configuration the "From" on a real email template (email_template), making this MP inappropriate.

Regards,
Xavier

review: Disapprove

Unmerged revisions

7138. By Amit Dodiya (OpenERP)

[FIX] smtp_server fix for identifying the correct smtp server for a incoming mail

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'fetchmail/fetchmail.py'
2--- fetchmail/fetchmail.py 2012-07-27 13:50:07 +0000
3+++ fetchmail/fetchmail.py 2013-02-11 08:49:05 +0000
4@@ -195,7 +195,7 @@
5 strip_attachments=(not server.attach),
6 context=context)
7 if res_id and server.action_id:
8- action_pool.run(cr, uid, [server.action_id.id], {'active_id': res_id, 'active_ids': [res_id], 'active_model': server.object_id.model})
9+ action_pool.run(cr, uid, [server.action_id.id], {'active_id': res_id, 'active_ids': [res_id], 'active_model': server.object_id.model, 'incoming_smtp_user_name': server.user})
10 imap_server.store(num, '+FLAGS', '\\Seen')
11 cr.commit()
12 count += 1
13@@ -220,7 +220,7 @@
14 strip_attachments=(not server.attach),
15 context=context)
16 if res_id and server.action_id:
17- action_pool.run(cr, uid, [server.action_id.id], {'active_id': res_id, 'active_ids': [res_id], 'active_model': server.object_id.model})
18+ action_pool.run(cr, uid, [server.action_id.id], {'active_id': res_id, 'active_ids': [res_id], 'active_model': server.object_id.model, 'incoming_smtp_user_name': server.user})
19 pop_server.dele(num)
20 cr.commit()
21 logger.info("fetched/processed %s email(s) on %s server %s", numMsgs, server.type, server.name)