Merge lp:~openerp-dev/openobject-addons/6.1-opw-583542-ado into lp:openobject-addons/6.1

[Amit Dodiya (OpenERP)]

Hello,

"[BACKPORT] error while confirming sale order when we have message size more than field size of procurement"

Error while writing the message for "Latest Error" field of procurement in other language when we have the content size more than field size.

Code is back-ported from 7.0

Regards,
Amit

[Xavier ALT (dex-phx)]

Hello Amit,

I regret, but DB field size changed are not allowed for stable branch.
I would prefer you to strip the message according to the field size, to ensure it will fit into the DB. Something like:

procurement/procurement.py:387
    message_field_max_sz = max(0, self.pool.get('procurement.order')._all_columns['message'].column.size) or None
    cr.execute('update procurement_order set message=%s where id=%s', (message[:message_field_max_sz], procurement.id))

Regards,
Xavier

review: Needs Fixing

[lp:~openerp-dev/openobject-addons/6.1-opw-583542-ado]

7121. By Amit Dodiya (OpenERP) on 2013-01-03

[FIX] error while confirming sale order when we have message size more than field size of procurement

[Amit Dodiya (OpenERP) (ado-openerp)]

Hello,

Thanks for the suggestion.
The code is changed.

Regards,
Amit Dodiya

review: Needs Resubmitting

[Naresh(OpenERP) (nch-openerp)]

Hi,

Rejecting this merge proposal for 6.1 as no more merge will take place in 6.1 a similar merge for 7 has been proposed
here:https://code.launchpad.net/~openerp-dev/openobject-addons/7.0-opw-584977-rgo/+merge/144931

Thanks,
Naresh Soni
OpenERP Enterprise Services

review: Disapprove

Unmerged revisions

7121. By Amit Dodiya (OpenERP) on 2013-01-03

[FIX] error while confirming sale order when we have message size more than field size of procurement

=== modified file 'procurement/procurement.py'
--- procurement/procurement.py	2012-01-04 06:38:07 +0000
+++ procurement/procurement.py	2013-01-03 04:47:22 +0000
@@ -383,8 +383,9 @@
                     message = _("Not enough stock.")
 
                 if message:
+                    message_field_max_sz = max(0, self.pool.get('procurement.order')._all_columns['message'].column.size) or None
                     self.log(cr, uid, procurement.id, _("Procurement '%s' is in exception: ") % (procurement.name) + message)
-                    cr.execute('update procurement_order set message=%s where id=%s', (message, procurement.id))
+                    cr.execute('update procurement_order set message=%s where id=%s', (message[:message_field_max_sz], procurement.id))
         return ok
 
     def action_produce_assign_service(self, cr, uid, ids, context=None):