Merge lp:~openerp-dev/openobject-addons/6.1-opw-581461-skh into lp:openobject-addons/6.1

Proposed by Somesh Khare
Status: Approved
Approved by: Vinay Rana (OpenERP)
Approved revision: 7057
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-581461-skh
Merge into: lp:openobject-addons/6.1
Diff against target: 29 lines (+9/-8)
1 file modified
point_of_sale/ (+9/-8)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-581461-skh
Reviewer Review Type Date Requested Status
Vinay Rana (OpenERP) (community) Approve
Naresh(OpenERP) Pending
Review via email:

Description of the change

Hello Sir,

[FIX]POS: Multi payments journal are not recorded as required.

In the Point of Sale environment when you make payment through multi Journal the Payment shows on the view eg: If you create sale order with any producy with the price 100$ and try to pay this in Sale Journal as 50 and Cash Journal as 50. You will see the journal on the POS view. But in POS Backend when you open the Order the payment tab have the entry for the 1st journal with the amount 100, where it should have the entry for the selected journal.

1. Create POS order with any product.
2. Try to make payment with multiple journals.
3. Validate the Order.
4. Open "PoS Backend/Reporting/All Sales Orders" and the Order see the payment tab.

This branch fixes this issue. Please share your view on it.

Thanks & Regards,
Somesh Khare

To post a comment you must log in.
Revision history for this message
Vinay Rana (OpenERP) (vra-openerp) wrote :

The Propose patch fixes the issue.

review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :


This bug was qualified as Not reproducible on Trunk ,If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Naresh Soni

Unmerged revisions

7057. By Somesh Khare

[FIX]POS: Multi payments journal are not recorded as required (Case: Ref 581461)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'point_of_sale/'
2--- point_of_sale/ 2012-02-13 16:12:01 +0000
3+++ point_of_sale/ 2012-11-05 10:55:26 +0000
4@@ -61,16 +61,17 @@
5 # the module behavior is the same when using the front-end or the back-end
6 statement_ids = order.pop('statement_ids')
7 order_id = self.create(cr, uid, order, context)
8- list.append(order_id)
9 # call add_payment; refer to wizard/pos_payment for data structure
10 # add_payment launches the 'paid' signal to advance the workflow to the 'paid' state
11- data = {
12- 'journal': statement_ids[0][2]['journal_id'],
13- 'amount': order['amount_paid'],
14- 'payment_name': order['name'],
15- 'payment_date': statement_ids[0][2]['name'],
16- }
17- order_obj.add_payment(cr, uid, order_id, data, context=context)
18+ for payments in statement_ids:
19+ payment = payments[2]
20+ order_obj.add_payment(cr, uid, order_id, data = {
21+ 'journal': payment['journal_id'],
22+ 'amount': payment['amount'],
23+ 'payment_name': payment['name'],
24+ 'payment_date': payment['name'],
25+ }, context=context)
26+ list.append(order_id)
27 return list
29 def unlink(self, cr, uid, ids, context=None):