Merge lp:~openerp-dev/openobject-addons/6.1-opw-580818-nep into lp:openobject-addons/6.1

Proposed by Nehal Panchal (OpenERP)
Status: Approved
Approved by: Naresh(OpenERP)
Approved revision: 7048
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-580818-nep
Merge into: lp:openobject-addons/6.1
Diff against target: 13 lines (+0/-3)
1 file modified
sale/ (+0/-3)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-580818-nep
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Approve
Review via email:

Description of the change


In Sales Order, when advance invoice is created and the invoice is validated the progress bar shows correct indication. But when the invoice is paid, the progress bar is 100% which is wrong.

For example:
1. Create Sales Order with price:100 of any Product.
2. Confirm Sales Order then create an advance invoice with price:50.
3. Validate the invoice, progress bar shows 50% which is correct.
4. Paid the invoice, progress bar shows 100% which is incorrect.

This fixes the issue.


To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) :
review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :


This bug was qualified as Not Relevant on Trunk as there is no progress bar anymore in treeview of Sale order and so this bug has no meaning anymore. If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Naresh Soni

Unmerged revisions

7048. By Nehal Panchal (OpenERP)

[FIX] sale: Fixed the issue of wrong indication of progress bar for partially created invoice of SO

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sale/'
2--- sale/ 2012-10-09 12:16:14 +0000
3+++ sale/ 2012-10-30 10:35:29 +0000
4@@ -130,9 +130,6 @@
5 def _invoiced_rate(self, cursor, user, ids, name, arg, context=None):
6 res = {}
7 for sale in self.browse(cursor, user, ids, context=context):
8- if sale.invoiced:
9- res[] = 100.0
10- continue
11 tot = 0.0
12 for invoice in sale.invoice_ids:
13 if invoice.state not in ('draft', 'cancel'):