Merge lp:~openerp-dev/openobject-addons/6.1-opw-579389-nep into lp:openobject-addons/6.1

[Nehal Panchal (OpenERP)]

Hello,

Invoice date of Create Invoices wizard is not considered while creating invoices.

Steps to reproduce:
1. Create Sales Order and confirm it.
2. Create Invoices through wizard and provide the Invoice date.

Provided date will not be shown in generated invoice.

This fixes the issue.

Thanks

[Naresh(OpenERP) (nch-openerp)]

 - return i.id
18 + if context:
19 + invoice.write(cr, uid, [i.id], {'date_invoice': context['date_inv']})
20 + continue

your code will break if there is no date_invoice key in the context.
The check should be for date exist in context i.e context.has_key(date_inv) if there is no date then its useless to call a write here. also use context.get(date_inv) to get the value.

Thanks,
Naresh

review: Needs Fixing

[Naresh(OpenERP) (nch-openerp)]

corrections:-

date_invoice should be read as date_inv ;)

[Nehal Panchal (OpenERP) (nep-openerp)]

Hello Sir,

I have done the changes as per your suggestion.

Thanks

review: Needs Resubmitting

[lp:~openerp-dev/openobject-addons/6.1-opw-579389-nep]

7004. By Nehal Panchal (OpenERP) on 2012-09-26

[FIX] sale : Invoice date of Create Invoices wizard is not considered while creating invoices

[Naresh(OpenERP) (nch-openerp)]

Hello,

This bug was qualified as Confirmed on Trunk (means still existing and reproducible). A Merge Proposal for trunk was created to fix it. Here is the link to follow the MP on Launchpad https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-opw-579389-port-mma/+merge/136633 and be informed once it's been merged in trunk: ... If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Thanks,
Naresh Soni

Unmerged revisions

7004. By Nehal Panchal (OpenERP) on 2012-09-26

[FIX] sale : Invoice date of Create Invoices wizard is not considered while creating invoices

=== modified file 'sale/sale.py'
--- sale/sale.py	2012-08-28 09:29:46 +0000
+++ sale/sale.py	2012-09-26 13:20:29 +0000
@@ -437,7 +437,7 @@
             'comment': order.note,
             'payment_term': order.payment_term and order.payment_term.id or False,
             'fiscal_position': order.fiscal_position.id or order.partner_id.property_account_position.id,
-            'date_invoice': context.get('date_invoice', False),
+            'date_invoice': context.get('date_inv', False),
             'company_id': order.company_id.id,
             'user_id': order.user_id and order.user_id.id or False
         }
@@ -536,8 +536,11 @@
         if not invoices:
             for o in self.browse(cr, uid, ids, context=context):
                 for i in o.invoice_ids:
+                    date_inv = context.get('date_inv', False)
                     if i.state == 'draft':
-                        return i.id
+                        if date_inv:
+                            invoice.write(cr, uid, [i.id], {'date_invoice': date_inv})
+                        continue
         for val in invoices.values():
             if grouped:
                 res = self._make_invoice(cr, uid, val[0][0], reduce(lambda x, y: x + y, [l for o, l in val], []), context=context)