Merge lp:~openerp-dev/openobject-addons/6.1-opw-578339-msh into lp:openobject-addons/6.1

Proposed by Mohammed Shekha(Open ERP)
Status: Approved
Approved by: Naresh(OpenERP)
Approved revision: 6961
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-578339-msh
Merge into: lp:openobject-addons/6.1
Diff against target: 47 lines (+4/-4)
3 files modified
account/partner_view.xml (+1/-1)
base_contact/base_contact_view.xml (+1/-1)
crm/crm_lead_view.xml (+2/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-578339-msh
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+121363@code.launchpad.net

Description of the change

Hello,

Fixed the issue of res.country.state, it has other required field than _rec_name so many2one of res.country.state quick create will always going to fail, hence disabled the quick create for state_id field.

Demo :- Sale -> Lead -> Open any existing form and try to create a state from many2one using quick create, you will see it will open a form popup for state creation, but in log it will raise an exception which is obvious because create is going to fail, if there are many2one which has more required field which is not going to create using name_create than why should we provide quick_create, hence remove quick create option.

Thanks.

To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello,

This bug was qualified as Not Relevant on Trunk (means that architecture on trunk has changed and so this bug has no meaning anymore). If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Thanks,
Naresh Soni

Unmerged revisions

6961. By Mohammed Shekha(Open ERP)

[FIX]Fixed the issue of quick create, res.country.state has other required field than _rec_name, so quick create always going to fail, hence disabled quick create.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account/partner_view.xml'
2--- account/partner_view.xml 2011-09-21 07:13:12 +0000
3+++ account/partner_view.xml 2012-08-27 05:46:24 +0000
4@@ -109,7 +109,7 @@
5 <field name="street"/>
6 <field name="city"/>
7 <field name="zip"/>
8- <field name="state_id"/>
9+ <field name="state_id" options='{"quick_create": false}'/>
10 <field name="country_id"/>
11 </group>
12 <group name="bank" colspan="2" col="2">
13
14=== modified file 'base_contact/base_contact_view.xml'
15--- base_contact/base_contact_view.xml 2012-01-31 13:36:57 +0000
16+++ base_contact/base_contact_view.xml 2012-08-27 05:46:24 +0000
17@@ -158,7 +158,7 @@
18 <field name="zip"/>
19 <field name="city"/>
20 <field name="country_id" />
21- <field name="state_id"/>
22+ <field name="state_id" options='{"quick_create": false}'/>
23 </form>
24 </field>
25 </record>
26
27=== modified file 'crm/crm_lead_view.xml'
28--- crm/crm_lead_view.xml 2012-04-20 09:24:45 +0000
29+++ crm/crm_lead_view.xml 2012-08-27 05:46:24 +0000
30@@ -94,7 +94,7 @@
31 <field name="zip"/>
32 <field name="city"/>
33 <field name="country_id"/>
34- <field name="state_id"/>
35+ <field name="state_id" options='{"quick_create": false}'/>
36 </group>
37 <group colspan="2" col="3">
38 <separator string="Communication" colspan="4" col="3"/>
39@@ -528,7 +528,7 @@
40 <field name="zip"/>
41 <field name="city"/>
42 <field name="country_id"/>
43- <field name="state_id"/>
44+ <field name="state_id" options='{"quick_create": false}'/>
45 </group>
46 <group colspan="2" col="2">
47 <separator string="Communication" colspan="2"/>