Merge lp:~openerp-dev/openobject-addons/6.1-opw-577744-dhs into lp:openobject-addons/6.1

Proposed by Dhruti Shastri(OpenERP)
Status: Work in progress
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-577744-dhs
Merge into: lp:openobject-addons/6.1
Diff against target: 55 lines (+10/-2)
3 files modified
sale_layout/i18n/nl.po (+2/-0)
sale_layout/report/report_sale_layout.rml (+6/-1)
sale_layout/sale_layout.py (+2/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-577744-dhs
Reviewer Review Type Date Requested Status
Dhruti Shastri(OpenERP) (community) Needs Resubmitting
Olivier Dony (Odoo) Needs Fixing
Naresh(OpenERP) Pending
Review via email: mp+120499@code.launchpad.net

Description of the change

Branch fixes following things,

1] The note description is printed, but not the note itself

2] The word “sub total” stays English

To post a comment you must log in.
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

This seems ok on first look, but if you modify a .rml file you should also modify the .sxw file in the same manner.

Thanks!

review: Needs Fixing
6957. By Quentin (OpenERP) <email address hidden>

[MERGE] fixes in account_voucher

6958. By Xavier ALT

[FIX] OPW 577963: ir_attachment: speed up ir.attachment search for large databases

6959. By Olivier Dony (Odoo)

[FIX] document: complete previous fix, restore sort order after filtering

6960. By Xavier ALT

[MERGE] BUG 1039664: edi: fix wrong cursor when generating edi_web_url_view

  regression from revid: <email address hidden>

6961. By Dhruti Shastri(OpenERP)

[FIX] : Sale_layout : SubTotal not translated, Note doesn't display not itself (case Ref: 577744)

Revision history for this message
Dhruti Shastri(OpenERP) (dhs-openerp) wrote :

I ahve made the changes in sxw according to rml

review: Needs Resubmitting
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello,

This bug was qualified as Not Relevant on Trunk (means that the sale_layout module is no more in trunk and so this bug has no meaning anymore). If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Thanks,
Naresh Soni

Unmerged revisions

6961. By Dhruti Shastri(OpenERP)

[FIX] : Sale_layout : SubTotal not translated, Note doesn't display not itself (case Ref: 577744)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sale_layout/i18n/nl.po'
2--- sale_layout/i18n/nl.po 2012-08-10 05:19:04 +0000
3+++ sale_layout/i18n/nl.po 2012-08-24 08:11:19 +0000
4@@ -23,7 +23,9 @@
5 msgstr "Orderreferentie moet uniek zijn per bedrijf!"
6
7 #. module: sale_layout
8+#: code:addons/sale_layout/sale_layout.py:82
9 #: selection:sale.order.line,layout_type:0
10+#, python-format
11 msgid "Sub Total"
12 msgstr "Subtotaal"
13
14
15=== modified file 'sale_layout/report/report_sale_layout.rml'
16--- sale_layout/report/report_sale_layout.rml 2012-03-15 18:11:12 +0000
17+++ sale_layout/report/report_sale_layout.rml 2012-08-24 08:11:19 +0000
18@@ -274,9 +274,14 @@
19 <blockTable colWidths="539.0" style="Table11">
20 <tr>
21 <td>
22- <para style="terp_default_9">[[ a['layout_type']=='text' and a['name'] or removeParentNode('blockTable') ]]</para>
23+ <para style="terp_default_9">[[ a['layout_type']=='text' and a['name'] or removeParentNode('blockTable') ]] </para>
24 </td>
25 </tr>
26+ <tr>
27+ <td>
28+ <para stype="terp_default_9">[[ a['note'] or removeParentNode('tr') ]] </para>
29+ </td>
30+ </tr>
31 </blockTable>
32 <pageBreak>[[ a['layout_type']!='break' and removeParentNode('pageBreak')]]</pageBreak>
33 <blockTable colWidths="198.0,85.0,71.0,57.0,57.0,71.0" style="Table13">
34
35=== modified file 'sale_layout/report/report_sale_layout.sxw'
36Binary files sale_layout/report/report_sale_layout.sxw 2011-05-10 09:14:36 +0000 and sale_layout/report/report_sale_layout.sxw 2012-08-24 08:11:19 +0000 differ
37=== modified file 'sale_layout/sale_layout.py'
38--- sale_layout/sale_layout.py 2012-02-14 23:24:48 +0000
39+++ sale_layout/sale_layout.py 2012-08-24 08:11:19 +0000
40@@ -22,6 +22,7 @@
41
42 from osv import fields, osv
43 import decimal_precision as dp
44+from tools.translate import _
45
46 class sale_order_line(osv.osv):
47
48@@ -78,7 +79,7 @@
49 if type == 'break':
50 temp['value']['name'] = ' '
51 if type == 'subtotal':
52- temp['value']['name'] = 'Sub Total'
53+ temp['value']['name'] = _('Sub Total')
54 return temp
55 return {}
56