Merge lp:~openerp-dev/openobject-addons/6.1-opw-577343-ado into lp:openobject-addons/6.1

Proposed by Amit Dodiya (OpenERP)
Status: Approved
Approved by: Naresh(OpenERP)
Approved revision: 6967
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-577343-ado
Merge into: lp:openobject-addons/6.1
Diff against target: 19 lines (+1/-2)
1 file modified
document/nodes.py (+1/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-577343-ado
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Approve
Xavier ALT Pending
Review via email: mp+121747@code.launchpad.net

Description of the change

Hello,

[FIX] when selecting external storage media for a document and when we access it thruough ftp it gives warning that Path is not directory

Steps:
1). Install document_ftp, configure storage media for external file storage
2). Create one directory and set Storage = External File Storage
3). Create one document and set directory = newly created directory for external file storage, save the document.
Now try to access the above created document you will face IO warning message "530:Path is not directory". It should open the newly created file.

Regards,
Amit Dodiya

To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) :
review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello,

This bug is not reproducible on Trunk and so this bug has no meaning anymore). If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Thanks,
Naresh Soni

Unmerged revisions

6967. By Atul Patel <email address hidden>

[FIX] when selecting external storage media for a document and when we access it thruough ftp it gives warning that Path is not directory

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'document/nodes.py'
2--- document/nodes.py 2011-12-19 16:54:40 +0000
3+++ document/nodes.py 2012-08-29 05:26:25 +0000
4@@ -240,6 +240,7 @@
5 s = []
6 if isinstance(self.path,list):
7 s+=self.path
8+ s = list(set(s))
9 elif self.path is None:
10 s.append('')
11 else:
12@@ -1244,8 +1245,6 @@
13 once caching is in, we might want to do that at init time and keep
14 this object anyway
15 """
16- if self.path or self.parent:
17- return
18 assert fbro
19 uid = self.context.uid
20