Merge lp:~openerp-dev/openobject-addons/6.1-opw-577189-skh into lp:openobject-addons/6.1

Proposed by Somesh Khare
Status: Approved
Approved by: Naresh(OpenERP)
Approved revision: 6928
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-577189-skh
Merge into: lp:openobject-addons/6.1
Diff against target: 18 lines (+1/-1)
1 file modified
account/account_invoice.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-577189-skh
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Approve
Review via email: mp+117417@code.launchpad.net

Description of the change

Hello Sir,

[Fix]: account_invoice: when you set option Skip Draft State for Manual Entries on sale journal invoice sequence number incremented

Steps to reproduce:
1 - Install account_cancel module
2 - Set "Skip 'Draft' State for Manual Entries" on sales journal
3 - Create a new invoice and validate it (eg:invoice number 'SAJ/2012/0001')
4 - Cancel the invoice and validate it again

Get 'SAJ/2012/0002' as invoice number

This branch fixes this issue. Kindly review the branch and please share your views.

Thanks,
Somesh Khare

To post a comment you must log in.
6926. By Olivier Dony (Odoo)

[FIX] portal: avoid making new portal users regular Employees

The menus were properly restricted but the portal users
created through the portal wizard on Partners were
erroneously made members of the Employee and Partner Manager
groups.
+ some cleanup in the context management

6927. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

6928. By Somesh Khare

[FIX]account_invoice: when you set option Skip Draft State for Manual Entries on sale journal invoice sequence number incremented(Case: Ref:577189)

Revision history for this message
Naresh(OpenERP) (nch-openerp) :
review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello,

This bug was qualified as Already Fixed on Trunk (means that it was already fixed and merged in Trunk). If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Thanks,
Naresh Soni

Unmerged revisions

6928. By Somesh Khare

[FIX]account_invoice: when you set option Skip Draft State for Manual Entries on sale journal invoice sequence number incremented(Case: Ref:577189)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account/account_invoice.py'
2--- account/account_invoice.py 2012-07-04 16:33:07 +0000
3+++ account/account_invoice.py 2012-08-01 06:12:20 +0000
4@@ -943,13 +943,13 @@
5 for i in line:
6 i[2]['period_id'] = period_id
7
8+ ctx.update(invoice=inv)
9 move_id = move_obj.create(cr, uid, move, context=ctx)
10 new_move_name = move_obj.browse(cr, uid, move_id, context=ctx).name
11 # make the invoice point to that move
12 self.write(cr, uid, [inv.id], {'move_id': move_id,'period_id':period_id, 'move_name':new_move_name}, context=ctx)
13 # Pass invoice in context in method post: used if you want to get the same
14 # account move reference when creating the same invoice after a cancelled one:
15- ctx.update({'invoice':inv})
16 move_obj.post(cr, uid, [move_id], context=ctx)
17 self._log_event(cr, uid, ids)
18 return True