Merge lp:~openerp-dev/openobject-addons/6.1-opw-577061-rha into lp:openobject-addons/6.1

Proposed by Rifakat Husen (OpenERP)
Status: Approved
Approved by: Naresh(OpenERP)
Approved revision: 6908
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-577061-rha
Merge into: lp:openobject-addons/6.1
Diff against target: 19 lines (+2/-0)
1 file modified
account_coda/wizard/ (+2/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-577061-rha
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Approve
Review via email:

Description of the change


Formatted IBAN account number by addind spaces while doing check with partner IBAN account number.

System automatically formats IBAN account numbers by adding spaces for better visualization(module base_iban),
but bank sends CODA file which has IBAN accounts without spaces, Ex. BE05735030524975

So it gives warning while we import any CODA file as partner account number(BE05 7350 3052 4975) does not
match with CODA file bank account number(BE05735030524975).

Please review this fix.

Rifakat Haradwala

To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) :
review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :


This bug was qualified as Already Fixed on Trunk (means that it was already fixed and merged in Trunk). If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Naresh Soni

Unmerged revisions

6908. By Rifakat Husen (OpenERP)

[FIX] account_coda: added spaces in account number while doing the check, systems stores account number with spaces and coda file account number doesn't have space

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_coda/wizard/'
2--- account_coda/wizard/ 2012-06-05 12:25:17 +0000
3+++ account_coda/wizard/ 2012-07-23 04:53:19 +0000
4@@ -28,6 +28,7 @@
5 import re
6 from traceback import format_exception
7 from sys import exc_info
8+from base_iban import base_iban
9 logger=netsvc.Logger()
11 class account_coda_import(osv.osv_memory):
12@@ -396,6 +397,7 @@
13 st_line['account_id'] = transfer_acc
14 match = True
15 elif find_partner:
16+ counterparty_number = base_iban._pretty_iban(base_iban._format_iban(counterparty_number))
17 bank_ids =,uid,[('acc_number','=', counterparty_number)])
18 if not match and find_partner and bank_ids:
19 if len(bank_ids) > 1: