Merge lp:~openerp-dev/openobject-addons/6.1-opw-576056-skh into lp:openobject-addons/6.1

Proposed by Somesh Khare
Status: Approved
Approved by: Priyesh (OpenERP)
Approved revision: 6855
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-576056-skh
Merge into: lp:openobject-addons/6.1
Diff against target: 11 lines (+1/-0)
1 file modified
sale/report/sale_report.py (+1/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-576056-skh
Reviewer Review Type Date Requested Status
Priyesh (OpenERP) (community) Approve
Naresh(OpenERP) Pending
Review via email: mp+111349@code.launchpad.net

Description of the change

Hello,

"[FIX]: Group by product filter in sales analysis report gives traceback when we have no sale order line in any sale order"

Steps:
1). Create a sale order with no sale order line and save it.
2). Goto : Sales/Reporting/Sales Analysis Report and open it.
3). Click on Clear button and try to group by with product / Reference UOM / Category of Product

It gives trackback.

Regards,
Somesh Khare

To post a comment you must log in.
Revision history for this message
Priyesh (OpenERP) (pso-openerp) :
review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello,

This bug was qualified as Already Fixed on Trunk (means that it was already fixed and merged in Trunk). If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Thanks,
Naresh Soni

Unmerged revisions

6855. By Amit Dodiya

[FIX] Sale_report: Group by product filter in sales analysis report gives traceback when we have no sale order line in any sale order(Case: ref 576056)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sale/report/sale_report.py'
2--- sale/report/sale_report.py 2011-12-19 16:54:40 +0000
3+++ sale/report/sale_report.py 2012-06-21 07:08:20 +0000
4@@ -97,6 +97,7 @@
5 left join product_template t on (p.product_tmpl_id=t.id)
6 left join product_uom u on (u.id=l.product_uom)
7 left join product_uom u2 on (u2.id=t.uom_id)
8+ where l.product_id is not null
9 group by
10 l.product_id,
11 l.product_uom_qty,