Code review comment for lp:~openerp-dev/openobject-addons/6.1-opw-575493-rha

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

in line 18 of the diff, you say

if 'hours' or 'user_id' in vals:

this is nasty as it always will be true, which will create a lot of bogus error messages to the user. the line should read

if 'hours' in vals or 'user_id' in vals

review: Needs Fixing

« Back to merge proposal