Merge lp:~openerp-dev/openobject-addons/6.1-opw-575460-pso into lp:openobject-addons/6.1

Proposed by Priyesh (OpenERP)
Status: Approved
Approved by: Vinay Rana (OpenERP)
Approved revision: 6829
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-575460-pso
Merge into: lp:openobject-addons/6.1
Diff against target: 14 lines (+4/-0)
1 file modified
account/ (+4/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-575460-pso
Reviewer Review Type Date Requested Status
Vinay Rana (OpenERP) (community) Approve
Olivier Dony (Odoo) Pending
Review via email:

Description of the change


To reproduce the issue:

Install point_of_sale module.
Go to the Accounting/Configuration/Financial Accounting/Journals/Journals.
Open the Bank statements.

It will raise an error like this:
NotImplementedError: Iteration is not allowed on browse_record(account.journal, 15)

I fixed this issue. Kindly review the branch and let me know your inputs on it.


To post a comment you must log in.
6829. By Priyesh (OpenERP)

[IMP] account: Added one more condition on ids(case:575460)

Revision history for this message
Vinay Rana (OpenERP) (vra-openerp) wrote :

The problem is happen with gtk client only, the propose patch will fix the issue.
As the ids should be check before passing this in to browse method directly.

review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :


This bug was qualified as Already Fixed on Trunk (means that it was already fixed and merged in Trunk). If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Naresh Soni

Unmerged revisions

6829. By Priyesh (OpenERP)

[IMP] account: Added one more condition on ids(case:575460)

6828. By Priyesh (OpenERP)

[FIX] account: Checked type of ids and set it as list for future process(case:575460)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account/'
2--- account/ 2012-03-22 12:24:19 +0000
3+++ account/ 2012-06-05 06:21:21 +0000
4@@ -824,6 +824,10 @@
6 @return: Returns a list of tupples containing id, name
7 """
8+ if not ids:
9+ return []
10+ if isinstance(ids, (int, long)):
11+ ids = [ids]
12 result = self.browse(cr, user, ids, context=context)
13 res = []
14 for rs in result: