Merge lp:~openerp-dev/openobject-addons/6.1-opw-575341-pso into lp:openobject-addons/6.1

Proposed by Priyesh (OpenERP)
Status: Approved
Approved by: Vinay Rana (OpenERP)
Approved revision: 6822
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-575341-pso
Merge into: lp:openobject-addons/6.1
Diff against target: 21 lines (+2/-2)
1 file modified
point_of_sale/static/src/js/pos.js (+2/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-575341-pso
Reviewer Review Type Date Requested Status
Vinay Rana (OpenERP) (community) Approve
Olivier Dony (Odoo) Pending
Review via email:

Description of the change


It should be possible to search on the reference and EAN field via the search field of the POS.
For now, its only possible with product name.

Kindly review the branch and let me know your inputs on it.


To post a comment you must log in.
Revision history for this message
Vinay Rana (OpenERP) (vra-openerp) wrote :

As this is the improvement which priyesh propose for extra searching option from POS front end, here end user can search POS product code vice also.

the propose fixes is correct and we can search using product code.

review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :


This bug was qualified as Confirmed on Trunk (means still existing and reproducible). A Merge Proposal for trunk was created to fix it. Here is the link to follow the MP on Launchpad and be informed once it's been merged in trunk: ... If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Naresh Soni

Unmerged revisions

6822. By Carlos Guerrero

[FIX] point_of_sale: Added search conditions for code and ean13 of the product in POS order search criteria(case:575341)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'point_of_sale/static/src/js/pos.js'
2--- point_of_sale/static/src/js/pos.js 2012-05-05 16:09:02 +0000
3+++ point_of_sale/static/src/js/pos.js 2012-06-01 10:55:22 +0000
4@@ -69,7 +69,7 @@
5 }, this));
6 }, this));
7 $.when(this.fetch('pos.category', ['name', 'parent_id', 'child_id']),
8- this.fetch('product.product', ['name', 'list_price', 'pos_categ_id', 'taxes_id', 'product_image_small', 'ean13', 'id'], [['pos_categ_id', '!=', false]]),
9+ this.fetch('product.product', ['name', 'list_price', 'pos_categ_id', 'taxes_id', 'product_image_small', 'code', 'ean13', 'id'], [['pos_categ_id', '!=', false]]),
10 this.fetch('product.packaging', ['product_id', 'ean']),
11 this.fetch('', ['account_id', 'currency', 'journal_id', 'state', 'name'],
12 [['state', '=', 'open'], ['user_id', '=', this.session.uid]]),
13@@ -1333,7 +1333,7 @@
14 s = $(this).val().toLowerCase();
15 if (s) {
16 m = products.filter( function(p) {
17- return != -1;
18+ return (String(p.code).toLowerCase().indexOf(s) != -1) || (String(p.ean13).toLowerCase().indexOf(s) != -1) || ( != -1);
19 });
20 $('.search-clear').fadeIn();
21 } else {