Merge lp:~openerp-dev/openobject-addons/6.1-opw-574812-skh into lp:openobject-addons/6.1

Proposed by Somesh Khare
Status: Approved
Approved by: Vinay Rana (OpenERP)
Approved revision: 6804
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-574812-skh
Merge into: lp:openobject-addons/6.1
Diff against target: 43 lines (+5/-5)
1 file modified
account_analytic_plans/account_analytic_plans_view.xml (+5/-5)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-574812-skh
Reviewer Review Type Date Requested Status
Vinay Rana (OpenERP) (community) Approve
Naresh(OpenERP) Pending
Review via email:

Description of the change

Hello Sir,

[FIX]account_analytic_plan : Error occurred journal_id not defined while creating the move line

Steps to reproduce:
Checked in web-client
1. Install account_analytic plan module.
2. Open Journal Entries from "Accounting/Journal Entries/Journal Entries"
3. Select Journal (eg: Cash) and create move line. Enter the value for required field such as, Name, Account and then select the Analytic Distribution.

Error Occurred:
ValueError: Error during evaluation of this context: "{'journal_id':journal_id}", message: "name 'journal_id' is not defined"

This branch fixes this issue.

Kindly review the branch and please share your views on it.

Somesh Khare

To post a comment you must log in.
Revision history for this message
Vinay Rana (OpenERP) (vra-openerp) wrote :

As I found duplicate fix which I approved previously which is not cover all xml code so this is better fix compare to MRA branch, as this fix is done previously so I am considering this one for approval.

review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :


This bug was qualified as Confirmed on Trunk (means still existing and reproducible). A Merge Proposal for trunk was created to fix it. Here is the link to follow the MP on Launchpad and be informed once it's been merged in trunk: ... If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Naresh Soni

Unmerged revisions

6804. By Somesh Khare

[FIX]account_analytic_plan : Error occurred journal_id not defined while creating the move line(Case: Ref 574812)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_analytic_plans/account_analytic_plans_view.xml'
2--- account_analytic_plans/account_analytic_plans_view.xml 2011-05-31 21:55:34 +0000
3+++ account_analytic_plans/account_analytic_plans_view.xml 2012-05-17 13:31:23 +0000
4@@ -23,10 +23,10 @@
5 <field name="inherit_id" ref="account.view_move_form"/>
6 <field name="arch" type="xml">
7 <xpath expr="/form/notebook/page/field[@name='line_id']/tree/field[@name='analytic_account_id']" position="replace">
8- <field name="analytics_id" context="{'journal_id':journal_id}" groups="analytic.group_analytic_accounting"/>
9+ <field name="analytics_id" context="{'journal_id':parent.journal_id}" groups="analytic.group_analytic_accounting"/>
10 </xpath>
11 <xpath expr="/form/notebook/page/field[@name='line_id']/form/notebook/page/group/field[@name='analytic_account_id']" position="replace">
12- <field name="analytics_id" context="{'journal_id':journal_id}" groups="analytic.group_analytic_accounting"/>
13+ <field name="analytics_id" context="{'journal_id':parent.journal_id}" groups="analytic.group_analytic_accounting"/>
14 </xpath>
15 </field>
16 </record>
17@@ -47,7 +47,7 @@
18 <field name="inherit_id" ref="account.view_move_line_form"/>
19 <field name="arch" type="xml">
20 <field name="analytic_account_id" position="replace">
21- <field name="analytics_id" context="{'journal_id':journal_id}" groups="analytic.group_analytic_accounting"/>
22+ <field name="analytics_id" context="{'journal_id':parent.journal_id}" groups="analytic.group_analytic_accounting"/>
23 </field>
24 </field>
25 </record>
26@@ -60,7 +60,7 @@
27 <field name="inherit_id" ref="account.view_move_line_form2"/>
28 <field name="arch" type="xml">
29 <field name="analytic_account_id" position="replace">
30- <field name="analytics_id" context="{'journal_id':journal_id}" groups="analytic.group_analytic_accounting"/>
31+ <field name="analytics_id" context="{'journal_id':parent.journal_id}" groups="analytic.group_analytic_accounting"/>
32 </field>
33 </field>
34 </record>
35@@ -73,7 +73,7 @@
36 <field name="inherit_id" ref="account.view_move_line_tree"/>
37 <field name="arch" type="xml">
38 <field name="analytic_account_id" position="replace">
39- <field name="analytics_id" context="{'journal_id':journal_id}" groups="analytic.group_analytic_accounting"/>
40+ <field name="analytics_id" context="{'journal_id':parent.journal_id}" groups="analytic.group_analytic_accounting"/>
41 </field>
42 </field>
43 </record>