Merge lp:~openerp-dev/openobject-addons/6.1-opw-574732-ado into lp:openobject-addons/6.1

[Amit Dodiya (OpenERP)]

Hello,

"[FIX] : incorrect rounding for residual amount field"

Steps :
1. Create an asset , set Time method = Number of depreciations, Number of depreciations = 23, Period length = 1
2. Value of the asset: 1500
3. Compute the depreciation board the first Depreciation line = 65.22
4. Now confirm the asset
5. Validate the first depreciation line
6. Reset the asset to draft
7. Change the value of the asset to 2100 and Compute the depreciation board

PROBLEM 1: Second line in depreciation board there is a incorrect rounding for column Amount already depreciated": 65 instead of 65.22
PROBLEM 2: If you compute the column "Depreciation amount" we do not obtain 2100

Regards,
Amit

[lp:~openerp-dev/openobject-addons/6.1-opw-574732-ado]

6795. By Amit Dodiya<email address hidden> on 2012-05-11

[FIX] : incorrect rounding for residual amount field

[Vinay Rana (OpenERP) (vra-openerp)]

The rounding issue is going to be solve by applying this patch.

review: Approve

[Naresh(OpenERP) (nch-openerp)]

Hello,

This bug was qualified as Confirmed on Trunk (means still existing and reproducible). A Merge Proposal for trunk was created to fix it. Here is the link to follow the MP on Launchpad https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-997141-cha/+merge/108553 and be informed once it's been merged in trunk: ... If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Thanks,
Naresh Soni

Unmerged revisions

6795. By Amit Dodiya<email address hidden> on 2012-05-11

[FIX] : incorrect rounding for residual amount field

=== modified file 'account_asset/account_asset.py'
--- account_asset/account_asset.py	2012-01-31 13:36:57 +0000
+++ account_asset/account_asset.py	2012-05-11 09:34:18 +0000
@@ -134,6 +134,7 @@
 
     def compute_depreciation_board(self, cr, uid, ids, context=None):
         depreciation_lin_obj = self.pool.get('account.asset.depreciation.line')
+        prec = self.pool.get('decimal.precision').precision_get(cr, uid, 'Account')
         for asset in self.browse(cr, uid, ids, context=context):
             if asset.value_residual == 0.0:
                 continue
@@ -158,6 +159,10 @@
             for x in range(len(posted_depreciation_line_ids), undone_dotation_number):
                 i = x + 1
                 amount = self._compute_board_amount(cr, uid, asset, i, residual_amount, amount_to_depr, undone_dotation_number, posted_depreciation_line_ids, total_days, depreciation_date, context=context)
+                asset.salvage_value = round(asset.salvage_value, prec)
+                asset.purchase_value = round(asset.purchase_value, prec)
+                residual_amount = round(residual_amount, prec)
+                amount = round(amount, prec)
                 residual_amount -= amount
                 vals = {
                      'amount': amount,
@@ -189,7 +194,7 @@
 
     def _amount_residual(self, cr, uid, ids, name, args, context=None):
         cr.execute("""SELECT
-                l.asset_id as id, round(SUM(abs(l.debit-l.credit))) AS amount
+                l.asset_id as id, SUM(abs(l.debit-l.credit)) AS amount
             FROM
                 account_move_line l
             WHERE