Merge lp:~openerp-dev/openobject-addons/6.1-opw-574178-pso into lp:openobject-addons/6.1

Proposed by Priyesh (OpenERP)
Status: Approved
Approved by: Vinay Rana (OpenERP)
Approved revision: 6780
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-574178-pso
Merge into: lp:openobject-addons/6.1
Diff against target: 30 lines (+5/-5)
1 file modified
account_bank_statement_extensions/account_bank_statement_view.xml (+5/-5)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-574178-pso
Reviewer Review Type Date Requested Status
Vinay Rana (OpenERP) (community) Approve
Xavier ALT Pending
Review via email:

Description of the change


Issue is only coming in web-client.

To produce the issue:
Install account_bank_statement_extensions module.
Open Bank Statement Lines.
Create a new one and try to set Account and Analytic Account.
It will raise an error.

I fixed this issue and improved usability in Bank statement line.

Priyesh Solanki

To post a comment you must log in.
Revision history for this message
Vinay Rana (OpenERP) (vra-openerp) wrote :

This issue is reproduce with some manual steps:
>open the Bank statement line
>Create a new line
>now directly try to select General Account or Analytic account will raises the error.

The propose fixes will fix the issue as per my test case.

Nice fix ...

review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :


This bug was qualified as Confirmed on Trunk (means still existing and reproducible). A Merge Proposal for trunk was created to fix it. Here is the link to follow the MP on Launchpad and be informed once it's been merged in trunk: ... If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Naresh Soni

Unmerged revisions

6780. By Priyesh (OpenERP)

[FIX] account_bank_statement_extensions: Removed use of parent in bank statement line and improved usability(case:574178)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_bank_statement_extensions/account_bank_statement_view.xml'
2--- account_bank_statement_extensions/account_bank_statement_view.xml 2012-01-31 13:36:57 +0000
3+++ account_bank_statement_extensions/account_bank_statement_view.xml 2012-05-01 07:28:18 +0000
4@@ -73,12 +73,12 @@
5 <field name="date" readonly="1" groups="base.group_extended"/>
6 <field name="val_date" readonly="1"/>
7 <field name="name"/>
8- <field name="statement_id" readonly="1"/>
9+ <field name="statement_id"/>
10 <field name="ref" readonly="1"/>
11 <field name="partner_id" on_change="onchange_partner_id(partner_id)"/>
12 <field name="type" on_change="onchange_type(partner_id, type)"/>
13- <field name="account_id" domain="[('journal_id','=',parent.journal_id)]"/>
14- <field name="analytic_account_id" groups="analytic.group_analytic_accounting" domain="[('company_id', '=', parent.company_id), ('type', '&lt;&gt;', 'view')]"/>
15+ <field name="account_id"/>
16+ <field name="analytic_account_id" groups="analytic.group_analytic_accounting" domain="[('type', '&lt;&gt;', 'view')]"/>
17 <field name="amount" readonly="1" sum="Total Amount"/>
18 <field name="globalisation_id" string="Glob. Id"/>
19 <field name="globalisation_amount" string="Glob. Am."/>
20@@ -101,8 +101,8 @@
21 <field name="ref" readonly="0"/>
22 <field name="partner_id" on_change="onchange_partner_id(partner_id)"/>
23 <field name="type" on_change="onchange_type(partner_id, type)"/>
24- <field domain="[('journal_id', '=', parent.journal_id), ('type', '&lt;&gt;', 'view')]" name="account_id"/>
25- <field name="analytic_account_id" groups="analytic.group_analytic_accounting" domain="[('company_id', '=', parent.company_id), ('type', '&lt;&gt;', 'view')]"/>
26+ <field domain="[('type', '&lt;&gt;', 'view')]" name="account_id"/>
27+ <field name="analytic_account_id" groups="analytic.group_analytic_accounting" domain="[('type', '&lt;&gt;', 'view')]"/>
28 <field name="amount"/>
29 <field name="globalisation_id"/>
30 <field name="sequence" readonly="0"/>