Merge lp:~openerp-dev/openobject-addons/6.1-opw-573801-rha into lp:openobject-addons/6.1

Proposed by Rifakat Husen (OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-573801-rha
Merge into: lp:openobject-addons/6.1
Diff against target: 11 lines (+1/-1)
1 file modified
mail/ (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-573801-rha
Reviewer Review Type Date Requested Status
Naresh(OpenERP) Pending
Review via email:

Description of the change


For Thunderbird plugin, OpenERP/Documents menu is not working when email does not have Message-ID. In that case, we create new float type message_id. I have changed type of newly created message_id from float to string because when an email has Message-ID, its type is string. Followed same type for new message_id too.

Thanks for your review.

Rifakat Haradwala

To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :


This bug was qualified as Not Relevant on Trunk (means that architecture on trunk has changed and so this bug has no meaning anymore). If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Naresh Soni

Unmerged revisions

6750. By Rifakat Husen (OpenERP)

[FIX] mail: if we don't get message_id by default then converted newly created meesage_id from type float to string

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mail/'
2--- mail/ 2012-03-20 08:20:59 +0000
3+++ mail/ 2012-04-23 09:45:23 +0000
4@@ -364,7 +364,7 @@
6 if not message_id:
7 # Very unusual situation, be we should be fault-tolerant here
8- message_id = time.time()
9+ message_id = tools.ustr(time.time())
10 msg_txt['message-id'] = message_id
11'Parsing Message without message-id, generating a random one: %s', message_id)