Code review comment for lp:~openerp-dev/openobject-addons/6.1-opw-573644-dhs

Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

It will be good if you have try ...except block for the move_to call...i.e

- res = fnode.move_to(cr, dnode or fnode.parent, vals.get('name', fbro.name), fbro, dbro, True)
+ try :
+ res = fnode.move_to(cr, dnode or fnode.parent, vals.get('name', fbro.name), fbro, dbro, True)
+ except Exception, e:
+ raise orm.except_orm(_('Error'), str(e))
                 if isinstance(res, dict):
                     vals2 = vals.copy()
                     vals2.update(res)

Thanks,

review: Needs Fixing

« Back to merge proposal