Merge lp:~openerp-dev/openobject-addons/6.1-opw-573631-msh into lp:openobject-addons/6.1

Proposed by Mohammed Shekha(Open ERP)
Status: Approved
Approved by: Naresh(OpenERP)
Approved revision: 6742
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-573631-msh
Merge into: lp:openobject-addons/6.1
Diff against target: 23 lines (+3/-3)
1 file modified
share/static/src/js/share.js (+3/-3)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-573631-msh
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Approve
Review via email:

Description of the change


Fixed the issue of context not passed in share from sidebar.

Here we have web-addons share in which we have added a share link in sidebar and launch wizard by calling the "go_step_1" method but here we have forgot to pass context, due to this the string of wizard title never comes language specific.

Hence changed the code.


To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) :
review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :


This bug was qualified as Confirmed on Trunk (means still existing and reproducible). A Merge Proposal for trunk was created to fix it. Here is the link to follow the MP on Launchpad and be informed once it's been merged in trunk: ... If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Unmerged revisions

6742. By Mohammed Shekha(Open ERP)

[FIX]Fixed the issue of context not passed in share.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'share/static/src/js/share.js'
2--- share/static/src/js/share.js 2011-12-27 20:36:18 +0000
3+++ share/static/src/js/share.js 2012-04-16 12:48:19 +0000
4@@ -11,16 +11,16 @@
5 self.rpc('/web/session/eval_domain_and_context', {
6 domains: [domain],
7 contexts: [view.dataset.context]
8- }, function (result) {
9+ }, function (results) {
10 Share.create({
11 name:,
12- domain: result.domain,
13+ domain: results.domain,
14 action_id:,
15 user_type: user_type || 'embedded',
16 view_type: view.fields_view.type,
17 }, function(result) {
18 var share_id = result.result;
19- var step1 ='go_step_1', [[share_id],], function(result) {
20+ var step1 ='go_step_1', [[share_id], results.context], function(result) {
21 var action = result;
22 self.do_action(action);
23 });