Merge lp:~openerp-dev/openobject-addons/6.1-opw-573299-skh into lp:openobject-addons/6.1

Proposed by Somesh Khare
Status: Rejected
Rejected by: Naresh(OpenERP)
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-573299-skh
Merge into: lp:openobject-addons/6.1
Diff against target: 17 lines (+2/-2)
1 file modified
account/account_move_line.py (+2/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-573299-skh
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Disapprove
Review via email: mp+100076@code.launchpad.net

Description of the change

Hello Sir,

[Fix]: Key Error: Journal_id occurred when creating Journal item from: Accounting/Journal Entries/Journal Items.

Kindly review the branch and please share your view on it.

Thanks,
Somesh Khare

To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

should be fixed from GTK

=== modified file 'bin/widget/view/tree_gtk/editabletree.py'
--- bin/widget/view/tree_gtk/editabletree.py 2010-12-23 09:52:21 +0000
+++ bin/widget/view/tree_gtk/editabletree.py 2012-05-07 10:28:46 +0000
@@ -198,6 +198,7 @@
             entry.editing_done_id = entry.connect('editing_done', self.on_editing_done, model)
         if event.keyval in self.leaving_model_events:
             if model.validate() and self.screen.tree_saves:
+ model.mgroup.setContext(self.screen.context)
                 id = model.save()
                 if not id:
                     return True

review: Disapprove

Unmerged revisions

6717. By Somesh Khare

[FIX] account.move.line: KeyError: Journal_id when creating journal item (Case: Ref 573299)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account/account_move_line.py'
2--- account/account_move_line.py 2012-03-06 16:10:40 +0000
3+++ account/account_move_line.py 2012-03-30 06:29:30 +0000
4@@ -489,11 +489,11 @@
5 'amount_residual_currency': fields.function(_amount_residual, string='Residual Amount', multi="residual", help="The residual amount on a receivable or payable of a journal entry expressed in its currency (maybe different of the company currency)."),
6 'amount_residual': fields.function(_amount_residual, string='Residual Amount', multi="residual", help="The residual amount on a receivable or payable of a journal entry expressed in the company currency."),
7 'currency_id': fields.many2one('res.currency', 'Currency', help="The optional other currency if it is a multi-currency entry."),
8- 'journal_id': fields.related('move_id', 'journal_id', string='Journal', type='many2one', relation='account.journal', required=True, select=True, readonly=True,
9+ 'journal_id': fields.related('move_id', 'journal_id', string='Journal', type='many2one', relation='account.journal', required=True, select=True,
10 store = {
11 'account.move': (_get_move_lines, ['journal_id'], 20)
12 }),
13- 'period_id': fields.related('move_id', 'period_id', string='Period', type='many2one', relation='account.period', required=True, select=True, readonly=True,
14+ 'period_id': fields.related('move_id', 'period_id', string='Period', type='many2one', relation='account.period', required=True, select=True,
15 store = {
16 'account.move': (_get_move_lines, ['period_id'], 20)
17 }),