Code review comment for lp:~openerp-dev/openobject-addons/6.1-opw-573096-ira

Revision history for this message
Julien Thewys (julien-thewys) wrote :

Forget about my last comment, I was not testing on the right environment.
Also my remark about "'contact_id' in" is false in this context.

So only the following is still true.
Thanks.

> 4. base_contact uses both firstname and lastname instead of name, so
> converting to partner should also copy the firstname. It means that the
> crm.lead form view must be adapted to display a firstname and a lastname
> field.
> 5. the email and the phone should not be saved on the contact but rather on
> the address (= on the job).
> Could you fix that also please?
>
> I just also saw that the create method you modified had an error prone
> signature:
> context={}
> instead of the idiom
> context=None

review: Needs Fixing

« Back to merge proposal