Merge lp:~openerp-dev/openobject-addons/6.0-opw-6344-rch into lp:openobject-addons/6.0

[Riken Bhorania (OpenERP)]

Restrict to create unwanted journal entries in the case of partial deductible tax scenario.

[qdp (OpenERP) (qdp)]

you need to make sure that the configuration of the taxes is correct.

Here the line with debit = credit = 0 is created because there is a value in tax_amount and tax_code_id fields. So this line is important. Either that vat information shouldn't be there (because it's already on another line, for example, and thus it means that the configuration is wrong) or it has to be there (and thus we can't just modify the code to remove those lines)

so i guess that the MP proposal is wrong

review: Disapprove

[Jay Vora (Serpent Consulting Services) (jayvora)]

Riken,

Can you please double check and finish this?

Thanks.

[Riken Bhorania (OpenERP) (rch-openerp)]

This merge proposal was designed for restricting the extra Journal Entry (debit=credit=0) created from the Invoice for the Tax configuration which is responsible to support partially deductible Tax scenario.

By verifying the tax configuration it seems that it must be as required which is correct also. However that extra Journal Entry (debit=credit=0) contains some value for 'Tax/Base Amount' column. This value is important and will be reflected on the 'Tax Report'. Also that Journal Entry (debit=credit=0) indicates parent-child relationship between taxes that are configured for this case.

According to me no further workout will be needed regarding this issue.

Unmerged revisions

4686. By Riken Bhorania (OpenERP) on 2011-07-01

[FIX]: account: Restrict to create unwanted journal entries in the case of partial tax deductible senario.

=== modified file 'account/invoice.py'
--- account/invoice.py	2011-06-21 14:56:58 +0000
+++ account/invoice.py	2011-07-01 13:35:52 +0000
@@ -1469,9 +1469,6 @@
                 if tax_code_found:
                     if not tax_code_id:
                         continue
-                    res.append(self.move_line_get_item(cr, uid, line, context))
-                    res[-1]['price'] = 0.0
-                    res[-1]['account_analytic_id'] = False
                 elif not tax_code_id:
                     continue
                 tax_code_found = True