Merge lp:~openerp-dev/openobject-addons/6.0-opw-5852-pso into lp:openobject-addons/6.0

[Priyesh (OpenERP)]

Hello,

Passed company in context during the Payment for Invoice the invoice in multi-company environment.
Improved find method of Period.

Thanks,
Priyesh

[qdp (OpenERP) (qdp)]

i guess that may fail again on *creation* of invoice... isn't it?

review: Needs Fixing

[Priyesh (OpenERP) (pso-openerp)]

Hello Quentin,
Thank you for your feedback and time.
But, Can you please give me an example how it can fail ?

Thanks,
Priyesh

[qdp (OpenERP) (qdp)]

if you don't give the company_id in the context, then it may fail, and you're not giving any special context for the invoice validation.

Also, the key used in the context should be 'force_company', as it will be that key that will be used for ir.property fields treatment in v6.1

so what you should do is:
company_id = user.company_id.id
if context.get('force_company',False):
   company_id = context['company_id']

(where user is a browse_record of uid.

Thanks

[Priyesh (OpenERP) (pso-openerp)]

Hello Quentin,

Thanks for your suggestion.

I have added company of user in default to stop failing if context is not correctly set.

Thanks,
Priyesh

review: Needs Resubmitting

=== modified file 'account/account.py'
--- account/account.py	2011-07-20 07:16:13 +0000
+++ account/account.py	2011-08-02 13:03:38 +0000
@@ -907,10 +907,17 @@
         return False
 
     def find(self, cr, uid, dt=None, context=None):
+        if context is None: context = {}
         if not dt:
             dt = time.strftime('%Y-%m-%d')
 #CHECKME: shouldn't we check the state of the period?
-        ids = self.search(cr, uid, [('date_start','<=',dt),('date_stop','>=',dt)])
+        args = [('date_start', '<=' ,dt), ('date_stop', '>=', dt)]
+        if context.get('company_id', False):
+            args.append(('company_id', '=', context['company_id']))
+        else:
+            company_id = self.pool.get('res.users').browse(cr, uid, uid, context=context).company_id.id
+            args.append(('company_id', '=', company_id))
+        ids = self.search(cr, uid, args, context=context)
         if not ids:
             raise osv.except_osv(_('Error !'), _('No period defined for this date: %s !\nPlease create a fiscal year.')%dt)
         return ids
@@ -1374,7 +1381,7 @@
         cr.execute('SELECT SUM(%s) FROM account_move_line WHERE move_id=%%s AND id!=%%s' % (mode,), (move.id, line_id2))
         result = cr.fetchone()[0] or 0.0
         cr.execute('update account_move_line set '+mode2+'=%s where id=%s', (result, line_id))
-        
+
         #adjust also the amount in currency if needed
         cr.execute("select currency_id, sum(amount_currency) as amount_currency from account_move_line where move_id = %s and currency_id is not null group by currency_id", (move.id,))
         for row in cr.dictfetchall():

=== modified file 'account_voucher/account_voucher.py'
--- account_voucher/account_voucher.py	2011-07-26 11:27:59 +0000
+++ account_voucher/account_voucher.py	2011-08-02 13:03:38 +0000
@@ -39,7 +39,10 @@
         if context is None: context = {}
         if context.get('period_id', False):
             return context.get('period_id')
-        periods = self.pool.get('account.period').find(cr, uid)
+        if context.get('invoice_id', False):
+            company_id = self.pool.get('account.invoice').browse(cr, uid, context['invoice_id'], context=context).company_id.id
+            context.update({'company_id': company_id})
+        periods = self.pool.get('account.period').find(cr, uid, context=context)
         return periods and periods[0] or False
 
     def _get_journal(self, cr, uid, context=None):
@@ -118,7 +121,7 @@
     def fields_view_get(self, cr, uid, view_id=None, view_type=False, context=None, toolbar=False, submenu=False):
         mod_obj = self.pool.get('ir.model.data')
         if context is None: context = {}
-        
+
         def get_res_id(view_type, condition):
             result = False
             if view_type == 'tree':
@@ -466,7 +469,7 @@
             domain = [('state','=','valid'), ('account_id.type', '=', account_type), ('reconcile_id', '=', False), ('partner_id', '=', partner_id)]
             if context.get('invoice_id', False):
 	            domain.append(('invoice', '=', context['invoice_id']))
-            ids = move_line_pool.search(cr, uid, domain, context=context)    
+            ids = move_line_pool.search(cr, uid, domain, context=context)
         else:
             ids = context['move_line_ids']
         ids.reverse()
@@ -535,7 +538,10 @@
         """
         period_pool = self.pool.get('account.period')
         res = self.onchange_partner_id(cr, uid, ids, partner_id, journal_id, price, currency_id, ttype, date, context=context)
-        pids = period_pool.search(cr, uid, [('date_start', '<=', date), ('date_stop', '>=', date)])
+        if context.get('invoice_id', False):
+            company_id = self.pool.get('account.invoice').browse(cr, uid, context['invoice_id'], context=context).company_id.id
+            context.update({'company_id': company_id})
+        pids = period_pool.find(cr, uid, date, context=context)
         if pids:
             if not 'value' in res:
                 res['value'] = {}