Merge lp:~openerp-dev/openobject-addons/6.0-opw-578969-cbi into lp:openobject-addons/6.0
Status: | Needs review |
---|---|
Proposed branch: | lp:~openerp-dev/openobject-addons/6.0-opw-578969-cbi |
Merge into: | lp:openobject-addons/6.0 |
Diff against target: |
63 lines (+11/-7) 1 file modified
survey/wizard/survey_send_invitation.py (+11/-7) |
To merge this branch: | bzr merge lp:~openerp-dev/openobject-addons/6.0-opw-578969-cbi |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
OpenERP Core Team | Pending | ||
Review via email:
|
Description of the change
To reproduce this issue, try to send invitations via the module survey.
On non-english-locale systems, this will cause a Traceback with a UnicodeDecodeError.
The cause of this is the function string.letters, called when generating the password.
This return only a-z,A-Z in english locale but also special characters in other locale.
The solution was to replace it with a call to string.
I also removed some unused code that has been there for a long time (2010) and was never used since, so it is not needed anymore. I figured that it was some old debugging code that was not removed.
Unmerged revisions
- 5352. By Chris Biersbach (OpenERP)
-
[FIX] A report was created in a directory where sometimes the user has no write access. I changed this to automatically detect the temporary folder of the OS and create the report there, which is always possible
- 5351. By Chris Biersbach (OpenERP)
-
[FIX] changed a call to string.letters into a call to string.
ascii_letters to avoid problems related to non-ascii characters. Also removed some unused code.