Merge lp:~openerp-dev/openobject-addons/6.0-opw-578572-dhs into lp:openobject-addons/6.0

Proposed by Dhruti Shastri(OpenERP)
Status: Work in progress
Proposed branch: lp:~openerp-dev/openobject-addons/6.0-opw-578572-dhs
Merge into: lp:openobject-addons/6.0
Diff against target: 70 lines (+2/-30)
3 files modified
sale_layout/report/report_sale_layout.py (+1/-1)
sale_layout/report/report_sale_layout.rml (+0/-28)
sale_layout/sale_layout_view.xml (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.0-opw-578572-dhs
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Needs Fixing
Review via email: mp+122805@code.launchpad.net

Description of the change

Sale_layout doesn't work with Pagebreak.

To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

I see a problem here. When you print the report without a page break tag you don't have the headers repeated any more if your order lines spans over more then 1 page.

secondly if you change the rml please change the sxw too.

Thanks,
Naresh

review: Needs Fixing

Unmerged revisions

5334. By Dhruti Shastri(OpenERP)

[FIX] sale_layout : PageBreak doesn't work (case: 578572)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sale_layout/report/report_sale_layout.py'
2--- sale_layout/report/report_sale_layout.py 2011-07-19 06:24:46 +0000
3+++ sale_layout/report/report_sale_layout.py 2012-09-05 07:37:29 +0000
4@@ -67,7 +67,7 @@
5 sub_total[i] = entry.price_subtotal and entry.price_subtotal
6 i = i + 1
7 res['note'] = entry.notes or ''
8- res['currency'] = sale_order.pricelist_id.currency_id.name
9+ res['currency'] = sale_order.pricelist_id.currency_id.symbol
10 res['layout_type'] = entry.layout_type
11 else:
12 res['product_uom_qty'] = ''
13
14=== modified file 'sale_layout/report/report_sale_layout.rml'
15--- sale_layout/report/report_sale_layout.rml 2012-01-16 14:49:03 +0000
16+++ sale_layout/report/report_sale_layout.rml 2012-09-05 07:37:29 +0000
17@@ -133,33 +133,6 @@
18 <images/>
19 </stylesheet>
20 <story>
21- <pto>
22- <pto_header>
23- <para style="terp_default_8">[[repeatIn(objects,'o')]]</para>
24- <para style="terp_default_8">[[ setLang(o.partner_id.lang) ]]</para>
25- <blockTable colWidths="198.0,85.0,71.0,57.0,57.0,71.0" style="Table7">
26- <tr>
27- <td>
28- <para style="terp_tblheader_Details">Description</para>
29- </td>
30- <td>
31- <para style="terp_tblheader_Details_Centre">VAT</para>
32- </td>
33- <td>
34- <para style="terp_tblheader_Details_Right">Quantity</para>
35- </td>
36- <td>
37- <para style="terp_tblheader_Details_Right">Unit Price</para>
38- </td>
39- <td>
40- <para style="terp_tblheader_Details_Right">Disc.(%)</para>
41- </td>
42- <td>
43- <para style="terp_tblheader_Details_Right">Price</para>
44- </td>
45- </tr>
46- </blockTable>
47- </pto_header>
48 <para style="terp_default_8">[[repeatIn(objects,'o')]]</para>
49 <para style="terp_default_8">[[ setLang(o.partner_id.lang) ]]</para>
50 <blockTable colWidths="260.0,64.0,215.0" style="Tableau2">
51@@ -392,6 +365,5 @@
52 <para style="Standard">
53 <font color="white"> </font>
54 </para>
55- </pto>
56 </story>
57 </document>
58
59=== modified file 'sale_layout/sale_layout_view.xml'
60--- sale_layout/sale_layout_view.xml 2011-01-14 00:11:01 +0000
61+++ sale_layout/sale_layout_view.xml 2012-09-05 07:37:29 +0000
62@@ -44,7 +44,7 @@
63 <separator colspan="4" string="Manual Description" />
64 <field name="layout_type" on_change="onchange_sale_order_line_view(layout_type)"/>
65 <field name="sequence" string="Seq."/>
66- <field colspan="4" name="name" select="2" attrs="{'readonly':[('layout_type','in',('line','break'))] }"/>
67+ <field colspan="4" name="name" select="2" attrs="{'readonly':[('layout_type','in',('line','break'))], 'required':[('layout_type','not in',['line','break'])]}"/>
68 <field name="price_unit" select="2" attrs="{'readonly':[('layout_type','!=','article')],'required':[('layout_type','not in',['title','text','subtotal','line','break'])]}"/>
69 <field name="discount" attrs="{'readonly':[('layout_type','!=','article')]}"/>
70 <field name="type" attrs="{'readonly':[('layout_type','!=','article')]}"/>