Merge lp:~openerp-dev/openobject-addons/6.0-opw-572587-rha into lp:openobject-addons/6.0

Proposed by Rifakat Husen (OpenERP)
Status: Merged
Approved by: Naresh(OpenERP)
Approved revision: no longer in the source branch.
Merged at revision: 5174
Proposed branch: lp:~openerp-dev/openobject-addons/6.0-opw-572587-rha
Merge into: lp:openobject-addons/6.0
Diff against target: 28 lines (+3/-3)
1 file modified
audittrail/audittrail.py (+3/-3)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.0-opw-572587-rha
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Approve
Review via email: mp+97642@code.launchpad.net

Description of the change

Hello,

Assign audittrail log name as blank in case logged object does not have name field.

If any object does not have name field in that case it tries to log name using resource['name'] and raised error(while create, update, delete).

Please review it.

Regards,
Rifakat

To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'audittrail/audittrail.py'
2--- audittrail/audittrail.py 2011-11-28 06:54:12 +0000
3+++ audittrail/audittrail.py 2012-03-15 13:23:19 +0000
4@@ -324,7 +324,7 @@
5 "object_id": model.id,
6 "user_id": uid_orig,
7 "res_id": resource['id'],
8- "name": resource['name'],
9+ "name": resource.get('name', ''),
10 }
11 if 'id' in resource:
12 del resource['id']
13@@ -389,7 +389,7 @@
14 "object_id": model.id,
15 "user_id": uid_orig,
16 "res_id": res_id,
17- "name" : v['name'],
18+ "name" : v.get('name', ''),
19 }
20 log_id = log_pool.create(cr, uid, vals)
21 lines = []
22@@ -444,7 +444,7 @@
23 "object_id": model.id,
24 "user_id": uid_orig,
25 "res_id": resource_id,
26- "name": resource['name'],
27+ "name": resource.get('name', ''),
28 }
29
30