Merge lp:~openerp-dev/openobject-addons/6.0-opw-51238-skh into lp:openobject-addons/6.0

Proposed by Somesh Khare
Status: Merged
Approved by: Naresh(OpenERP)
Approved revision: 4980
Merge reported by: nel
Merged at revision: not available
Proposed branch: lp:~openerp-dev/openobject-addons/6.0-opw-51238-skh
Merge into: lp:openobject-addons/6.0
Diff against target: 31 lines (+3/-4)
1 file modified
hr_timesheet_invoice/wizard/hr_timesheet_invoice_create.py (+3/-4)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.0-opw-51238-skh
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Approve
Vinay Rana (OpenERP) Pending
Review via email: mp+86784@code.launchpad.net

Description of the change

Hello Sir,

Scenario:
     Create two service type product, prestations, régie.
        1. Select the timesheet tab on the Employee "Admin" form and select the product "prestations" , who have no taxes
        2. Give the taxes on the Product "régie" (basic taxes for sales and purchase)
        3. The user "Admin" do a sign in and a sign out from the " Human Resources/Attendances/Sign in / Sign out by project".

When you run the wizard for Billing Data from "Accounting/Periodical Processing/Billing/Bill Tasks Works" It creates a invoice for the product, which you provided on the Wizard form. Invoice has no taxes for the product "régie".

[Fix]: This branch fixes this issue.

Kindly review the branch and share your views on it.

Thanks,
Somesh Khare

To post a comment you must log in.
4975. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4976. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4977. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4978. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4979. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

4980. By Somesh Khare

[IMP]]hr_timesheet_invoice_create: Invoice line product did not have taxes given by the wizard(Ref: Case 51238)

Revision history for this message
Naresh(OpenERP) (nch-openerp) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hr_timesheet_invoice/wizard/hr_timesheet_invoice_create.py'
2--- hr_timesheet_invoice/wizard/hr_timesheet_invoice_create.py 2011-04-21 07:45:29 +0000
3+++ hr_timesheet_invoice/wizard/hr_timesheet_invoice_create.py 2011-12-29 12:42:24 +0000
4@@ -120,15 +120,16 @@
5 raise osv.except_osv(_('Error'), _('At least one line has no product !'))
6 factor_name = ''
7 factor = invoice_factor_obj.browse(cr, uid, factor_id, context2)
8-
9 if not data['product']:
10 if factor.customer_name:
11 factor_name = product.name+' - '+factor.customer_name
12 else:
13 factor_name = product.name
14+ taxes = product.taxes_id
15 else:
16 factor_name = product_obj.name_get(cr, uid, [data['product']], context=context)[0][1]
17-
18+ taxes = product_obj.browse(cr,uid,data['product'],context).taxes_id
19+
20 ctx = context.copy()
21 ctx.update({'uom':uom})
22 if account.pricelist_id:
23@@ -136,8 +137,6 @@
24 price = pro_price_obj.price_get(cr,uid,[pl], data['product'] or product_id, qty or 1.0, account.partner_id.id, context=ctx)[pl]
25 else:
26 price = 0.0
27-
28- taxes = product.taxes_id
29 tax = fiscal_pos_obj.map_tax(cr, uid, account.partner_id.property_account_position, taxes)
30 account_id = product.product_tmpl_id.property_account_income.id or product.categ_id.property_account_income_categ.id
31 curr_line = {