Merge lp:~openerp-dev/openobject-addons/6.0-opw-51081-rha into lp:openobject-addons/6.0

Proposed by Rifakat Husen (OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/6.0-opw-51081-rha
Merge into: lp:openobject-addons/6.0
Diff against target: 53 lines (+8/-4)
3 files modified
procurement/procurement.py (+1/-1)
procurement/schedulers.py (+2/-2)
purchase/purchase.py (+5/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.0-opw-51081-rha
Reviewer Review Type Date Requested Status
nel Pending
Review via email: mp+86683@code.launchpad.net

Description of the change

Hello,

Fixed problem of creating extra procurement move when order point location is chained location and also do not consider of warehouse from order point when PO is generated while running scheduler.

Thanks for review.
Let me know if any correction needed.

Regards,
Rifakat

To post a comment you must log in.

Unmerged revisions

4973. By Rifakat Husen (OpenERP)

[FIX] procurement: fix problems raising from scheduler
* creating extra move from scheduler
* do not consider warehouse of order point for PO creating from procurement

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'procurement/procurement.py'
2--- procurement/procurement.py 2011-03-10 09:52:41 +0000
3+++ procurement/procurement.py 2011-12-22 10:59:53 +0000
4@@ -340,7 +340,7 @@
5 'company_id': procurement.company_id.id,
6 'auto_validate': True,
7 })
8- move_obj.action_confirm(cr, uid, [id], context=context)
9+ move_obj.write(cr, uid, [id], {'state': 'confirmed'}, context=context)
10 self.write(cr, uid, [procurement.id], {'move_id': id, 'close_move': 1})
11 self.write(cr, uid, ids, {'state': 'confirmed', 'message': ''})
12 return True
13
14=== modified file 'procurement/schedulers.py'
15--- procurement/schedulers.py 2011-01-14 00:11:01 +0000
16+++ procurement/schedulers.py 2011-12-22 10:59:53 +0000
17@@ -266,10 +266,10 @@
18 })
19 wf_service.trg_validate(uid, 'procurement.order', proc_id,
20 'button_confirm', cr)
21- wf_service.trg_validate(uid, 'procurement.order', proc_id,
22- 'button_check', cr)
23 orderpoint_obj.write(cr, uid, [op.id],
24 {'procurement_id': proc_id}, context=context)
25+ wf_service.trg_validate(uid, 'procurement.order', proc_id,
26+ 'button_check', cr)
27 offset += len(ids)
28 if use_new_cursor:
29 cr.commit()
30
31=== modified file 'purchase/purchase.py'
32--- purchase/purchase.py 2011-12-06 16:23:01 +0000
33+++ purchase/purchase.py 2011-12-22 10:59:53 +0000
34@@ -816,6 +816,9 @@
35 context.update({'lang': partner.lang, 'partner_id': partner_id})
36
37 product = prod_obj.browse(cr, uid, procurement.product_id.id, context=context)
38+ order_point_id = self.pool.get('stock.warehouse.orderpoint').search(cr, uid, [('procurement_id','=', procurement.id)])
39+ if order_point_id:
40+ order_point_warehouse_id = self.pool.get('stock.warehouse.orderpoint').browse(cr, uid, order_point_id[0], context=context).warehouse_id.id
41
42 line = {
43 'name': product.partner_ref,
44@@ -841,7 +844,8 @@
45 'pricelist_id': pricelist_id,
46 'order_line': [(0,0,line)],
47 'company_id': procurement.company_id.id,
48- 'fiscal_position': partner.property_account_position and partner.property_account_position.id or False
49+ 'fiscal_position': partner.property_account_position and partner.property_account_position.id or False,
50+ 'warehouse_id': order_point_warehouse_id or False
51 })
52 res[procurement.id] = purchase_id
53 self.write(cr, uid, [procurement.id], {'state': 'running', 'purchase_id': purchase_id})